Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jpg orientation changes #20

Closed
Antony74 opened this issue Mar 1, 2016 · 5 comments
Closed

jpg orientation changes #20

Antony74 opened this issue Mar 1, 2016 · 5 comments

Comments

@Antony74
Copy link

Antony74 commented Mar 1, 2016

Here's one of my wedding photos. What happens when you try to Leanify it, please?

http://akb.me.uk/IMG_2575.jpg

When I try, the orientation changes from portrait to landscape. I think this might be a bug, and the orientation should stay the same?

grab

@JayXon
Copy link
Owner

JayXon commented Mar 1, 2016

Thanks for your report!
The image is indeed stored in landscape, you were seeing it in portrait before because there's information about orientation stored in the exif.
Take a look at the exif information of your image here: http://regex.info/exif.cgi?imgurl=http%3A%2F%2Fakb.me.uk%2FIMG_2575.jpg
In the orientation section, it tells the viewer to rotate the image 270 degree clockwise.
However, currently leanify removes exif by default, but if you use --keep-exif, the orientation keep the same.
For personal photos that you want to keep on your disk, I would recommend always keep the exif, as it may also contains information about the time the photo is taken, the camera you're using, etc. However, if you are going to post it on your website, you probably want to make it as small as possible to save your website bandwidth and make your website load faster, in addition, you might not want people to know too much detail like the location where the photo is taken.
Leanify probably should be more smart at this, e.g. keep exif if there's orientation in it, or maybe keep exif by default and provide another option to remove it.

@Antony74
Copy link
Author

Antony74 commented Mar 2, 2016

Thank you very much for your response - and your insight into the curious world of file formats!

@Antony74
Copy link
Author

e.g. keep exif if there's orientation in it, or maybe keep exif by default and provide another option to remove it.

I'd probably go with "print a warning if an exif with orientation in it is removed" since that keeps everything else about the behavior of Leanify exactly as it was.

By the way, if I run Leanify without any parameters, then it displays usage information which doesn't mention the --keep-exif option.

@JayXon
Copy link
Owner

JayXon commented Apr 1, 2016

Thanks for the suggestion, warning sounds good.
Are you sure --keep-exif is not there? It's the last option, what version are you using?

@Antony74
Copy link
Author

Antony74 commented Apr 1, 2016

Sorry, my mistake. The Chocolately package is one version out of date.

leanify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants