Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTLM authentication adds a dependency even if you don't need it #44

Closed
jenkin opened this issue Oct 27, 2016 · 5 comments
Closed

NTLM authentication adds a dependency even if you don't need it #44

jenkin opened this issue Oct 27, 2016 · 5 comments

Comments

@jenkin
Copy link

jenkin commented Oct 27, 2016

It's the pip package requests_ntlm. I'm using Python 2.7.3 on Debian 7.11. Maybe you can import the ntlm module only if the ELASTICSEARCH_AUTH parameters has NTLM value?

@jsgervais
Copy link

I'm not sure it can be done if some parameters have some values, however, I think you can import a package when it's available with precompiling conditions and then assert in the code if it is available.

@jayzeng
Copy link
Owner

jayzeng commented Nov 5, 2016

Looks like I can use extra_require in setup tools (https://setuptools.readthedocs.io/en/latest/setuptools.html#declaring-extras-optional-features-with-their-own-dependencies), let me play around it

@jayzeng
Copy link
Owner

jayzeng commented Nov 5, 2016

#47

@jayzeng
Copy link
Owner

jayzeng commented Nov 5, 2016

@jenkin @jsgervais I made the changes and pushed a build to pypi, will be great if you guys can give it a test.

@jayzeng
Copy link
Owner

jayzeng commented Nov 5, 2016

Going to close this issue, please re-open if it doesn't work.

@jayzeng jayzeng closed this as completed Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants