Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Jazzband guidelines for project django-oauth-toolkit #94

Closed
9 tasks done
jazzband-bot opened this issue Apr 8, 2018 · 15 comments
Closed
9 tasks done

Comments

@jazzband-bot
Copy link
Contributor

jazzband-bot commented Apr 8, 2018

This issue tracks the implementation of the Jazzband guidelines for the project django-oauth-toolkit

It was initiated by @synasius who was automatically assigned in addition to the Jazzband roadies.

See the TODO list below for the generally required tasks, but feel free to update it in case the project requires it.

Feel free to ping a Jazzband roadie if you have any question.

TODOs

  • Fix all links in the docs (and README file etc) from old to new repo
  • Add the Jazzband badge to the README file
  • Add the Jazzband contributing guideline to the CONTRIBUTING.md file
  • Check if continuous testing works (e.g. Travis-CI, CircleCI, AppVeyor, etc)
  • Check if test coverage services work (e.g. Coveralls, Codecov, etc)
  • Add jazzband account to PyPI project as maintainer role (URL: https://pypi.python.org/pypi?:action=role_form&package_name=<PROJECTNAME>)
  • Add jazzband-bot as maintainer to the Read the Docs project (URL: https://readthedocs.org/dashboard/<PROJECTNAME>/users/)
  • Fix project URL in GitHub project description
  • Review project if other services are used and port them to Jazzband

Project details

Description OAuth2 goodies for the Djangonauts!
Homepage http://dot.evonove.it/
Stargazers 1242
Open issues 105
Forks 404
Default branch master
Is a fork False
Has Wiki False
Has Pages False
@jezdez
Copy link
Member

jezdez commented Apr 8, 2018

@synasius Hey there, about the homepage http://dot.evonove.it/, it'd be best to move that to GitHub pages and set up a redirect from the old URL.

@jleclanche
Copy link
Member

The README also has a reference to a security email which is not maintained by jazzband. @jezdez how does jazzband usually handle security issues?

@jezdez
Copy link
Member

jezdez commented Apr 9, 2018

@jleclanche We don't go into detail about the response time etc (by design), but there is also an email address: https://jazzband.co/security

@synasius
Copy link

synasius commented Apr 10, 2018

@jezdez Sure we can move the homepage to github pages!

@synasius
Copy link

@jezdez I just checked and dot.evonove.it is already on Github Pages using a custom domain
here is the pubic repository https://github.com/evonove/dot.evonove.it

@jleclanche
Copy link
Member

@synasius iirc we can move it to a gh-pages branch on the django-oauth-toolkit repo and thatll get picked up automatically.

@jezdez
Copy link
Member

jezdez commented Apr 10, 2018

@jleclanche That'd be great, yeah.

@synasius
Copy link

@jezdez @jleclanche I just pushed the gh-pages branch. I guess we need to set it up in the repo's settings

@jezdez
Copy link
Member

jezdez commented Apr 10, 2018

Hmpf, it's enabled, but I think https://help.github.com/articles/user-organization-and-project-pages/ makes it clear it needs to live in an own repo called django-oauth-toolkit.github.io, which isn't something we should do to make maintenance easier. Instead, please let's just move the page into a Sphinx project or something, it's just not worth the exception to have separate repos for the static pages.

@synasius
Copy link

@jezdez thought it should be available under http://jazzband.github.io/django-oauth-toolkit

Project Pages sites are connected to a specific project, and the site files live on a branch within the project repository.

@jezdez
Copy link
Member

jezdez commented Apr 10, 2018

Uh, lemme check again..

@jezdez
Copy link
Member

jezdez commented Apr 10, 2018

Okay, changing the source and resaving it worked at least for the rendering: https://jazzband.github.io/django-oauth-toolkit/

That said, a few questions:

  1. The content of the branch seems to be the static output from the https://github.com/evonove/dot.evonove.it repo, which is not what we want, since it's hard to maintain it without the original content.

  2. The paths in the static files are still linking to the old URL.

Unless there is an easy (read: trivial for me) way to maintain this I'm going to have to decline hosting the static site. Instead, please move the content to the Sphinx docs so we can use ReadTheDocs for automated rendering. The goal is to have as little maintenance burden going forward as possible.

@jleclanche
Copy link
Member

The content of the branch seems to be the static output from the https://github.com/evonove/dot.evonove.it repo, which is not what we want, since it's hard to maintain it without the original content.

gh-pages don't support hugo so we'll probably have to convert to jekyll

@n2ygk
Copy link
Member

n2ygk commented Jun 26, 2018

See #101

@jezdez
Copy link
Member

jezdez commented Sep 17, 2019

I think this is done, please let me know if there is anything else needed for the GitHub pages bit to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants