Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HubSpot tracking code #38

Closed
craigbruce opened this issue May 9, 2014 · 2 comments
Closed

Update HubSpot tracking code #38

craigbruce opened this issue May 9, 2014 · 2 comments

Comments

@craigbruce
Copy link

The tracking code for HubSpot is out of date. It is now async and only requires your Hub/Portal ID (no domain). I'm proposing I update the code and remove the HUBSPOT_DOMAIN variable.

You can see snippet of the new code at the base of http://knowledge.hubspot.com/getting-started-with-hubspot/how-to-install-the-tracking-code-on-a-generic-website

Any objections to writing a PR for this?

@jcassee
Copy link
Collaborator

jcassee commented May 11, 2014

Hi Craig,

Absolutely not, please create a PR and I'll merge in the required changes. Thanks for picking this up.

Joost

@jcassee
Copy link
Collaborator

jcassee commented Jul 6, 2014

Fixed in #39. Thanks Craig!

@jcassee jcassee closed this as completed Jul 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants