Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ConfigurationLoader to use the PEP-451 style loader #385

Open
adamchainz opened this issue May 9, 2024 · 0 comments · May be fixed by #386
Open

Move ConfigurationLoader to use the PEP-451 style loader #385

adamchainz opened this issue May 9, 2024 · 0 comments · May be fixed by #386

Comments

@adamchainz
Copy link
Contributor

adamchainz commented May 9, 2024

Running a project with django-configurations and python -Wall shows this warning:

$ python -Wall manage.py help
<frozen importlib._bootstrap>:918: ImportWarning: ConfigurationLoader.exec_module() not found; falling back to load_module()
...

This is from Python’s frozen importlib reporting that Configurationloader uses the pre-PEP-451 load_module() method, rather than the newer exec_module(). PEP 451 was merged in Python 3.4, so we can safely migrate to exec_module() and prevent that warning.

@adamchainz adamchainz linked a pull request May 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant