Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] PostgreSQL backup leaks password in command-line #384

Open
Natureshadow opened this issue Feb 17, 2021 · 0 comments · May be fixed by #385
Open

[Security] PostgreSQL backup leaks password in command-line #384

Natureshadow opened this issue Feb 17, 2021 · 0 comments · May be fixed by #385

Comments

@Natureshadow
Copy link

The PostgreSQL dumping code produces a database URI that is then passed verbatim on the pg_dump command-line.

Command lines are considered public, because normally, everyone with shell access to a system can read them (by calling ps or looking inside /proc).

All utilities using libpq can be configured using environment variables for this exact reason, which I will propose in a merge request.

As of Django 3.2, the DatabaseClient class will have a settings_to_cmd_args_env method that does exactly this, but we cannot yet use it for backwards compatibility.

Natureshadow added a commit to Natureshadow/django-dbbackup that referenced this issue Feb 17, 2021
Natureshadow added a commit to Natureshadow/django-dbbackup that referenced this issue Feb 17, 2021
Natureshadow added a commit to Natureshadow/django-dbbackup that referenced this issue Feb 17, 2021
Natureshadow added a commit to Natureshadow/django-dbbackup that referenced this issue Feb 17, 2021
Natureshadow added a commit to Natureshadow/django-dbbackup that referenced this issue Feb 17, 2021
Natureshadow added a commit to Natureshadow/django-dbbackup that referenced this issue Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant