Add check for filename template values #484
Open
+66
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on #483 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #484 +/- ##
==========================================
+ Coverage 91.21% 91.33% +0.12%
==========================================
Files 19 19
Lines 854 866 +12
Branches 150 152 +2
==========================================
+ Hits 779 791 +12
Misses 40 40
Partials 35 35 ☔ View full report in Codecov by Sentry. |
|
@jerinpetergeorge Can you update the hint to also suggest changing Maybe adding another sentence like I'm not sure if there's an equivalent for media storage? This PR can be merged after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR - Enhancement
Description
This PR will check whether the values of
DBBACKUP_FILENAME_TEMPLATEandDBBACKUP_MEDIA_FILENAME_TEMPLATEcontains any "slashes" (/) in it (Ref: #479 ).Why should this be added
If the filename contains slashes, the storage will create a directory out of it and the
--cleanflag won't work as expected.