Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonitorField doesnt work on proxy models #287

Open
vosi opened this issue Jul 17, 2017 · 0 comments
Open

MonitorField doesnt work on proxy models #287

vosi opened this issue Jul 17, 2017 · 0 comments

Comments

@vosi
Copy link

vosi commented Jul 17, 2017

Problem

class Model:
    field1 = MonitorField(monitor=field2)
    field2 = SomeField()


class ProxyModel:
    class Meta:
        proxy = True

Environment

  • Django Model Utils version: 3.0.0
  • Django version: 1.10.7
  • Python version: 2.7
  • Other libraries used, if any: ...

Code examples

our "sollution"

class CustomMonitorField(MonitorField):
     def pre_save(self, model_instance, add):
         value = now()
         previous_instance = model_instance.__class__.objects.get(pk=model_instance.pk)
         previous = self.get_monitored_value(previous_instance)
         current = self.get_monitored_value(model_instance)
         if previous != current:
             if self.when is None or current in self.when:
                 setattr(model_instance, self.attname, value)
                 self._save_initial(model_instance.__class__, model_instance)
         return super(MonitorField, self).pre_save(model_instance, add)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant