Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maint] Resolve failing djmain tests #1064

Closed
n2ygk opened this issue Dec 30, 2021 · 5 comments
Closed

[maint] Resolve failing djmain tests #1064

n2ygk opened this issue Dec 30, 2021 · 5 comments
Assignees
Milestone

Comments

@n2ygk
Copy link
Member

n2ygk commented Dec 30, 2021

Tox tests are currently failing with djmain. Figure out and resolve before the next Django 4.x release is published and those tests fail too.

@n2ygk n2ygk added this to the 1.7.0 milestone Dec 30, 2021
@n2ygk
Copy link
Member Author

n2ygk commented Jan 1, 2022

Also need to change the gh workflow to flag the failures. They are currently buried and don't show up.

@n2ygk
Copy link
Member Author

n2ygk commented Jan 3, 2022

Something has changed between Django 4.0 and main branch leading to an attempt to do an unsupported SQLIte3 operation:

self = <django.db.backends.sqlite3.base.SQLiteCursorWrapper object at 0x10b8038b0>
query = 'ALTER TABLE "oauth2_provider_accesstoken" ADD COLUMN "source_refresh_token_id" bigint NULL UNIQUE REFERENCES "oauth2_provider_refreshtoken" ("id") DEFERRABLE INITIALLY DEFERRED'
params = []

    def execute(self, query, params=None):
        if params is None:
            return Database.Cursor.execute(self, query)
        query = self.convert_query(query)
>       return Database.Cursor.execute(self, query, params)
E       django.db.utils.OperationalError: Cannot add a UNIQUE column

@n2ygk
Copy link
Member Author

n2ygk commented Jan 3, 2022

I've opened this upstream Django ticket: https://code.djangoproject.com/ticket/33408

@n2ygk
Copy link
Member Author

n2ygk commented Jan 3, 2022

Fixed here: django/django#15278

@n2ygk
Copy link
Member Author

n2ygk commented Jan 4, 2022

Upstream fix has been merged. djmain tests are succeeding again.

gh workflow question is being discussed at https://github.com/orgs/jazzband/teams/django-oauth-toolkit/discussions/2

@n2ygk n2ygk closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants