Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is still missing w.r.t. hashed secrets #1238

Open
2 tasks done
n2ygk opened this issue Dec 29, 2022 · 1 comment
Open
2 tasks done

Documentation is still missing w.r.t. hashed secrets #1238

n2ygk opened this issue Dec 29, 2022 · 1 comment
Labels

Comments

@n2ygk
Copy link
Member

n2ygk commented Dec 29, 2022

Describe the bug

In DOT 2.x the client_secret is now stored hashed. Documentation (including warning text in the HTML template) was added for the admin UI but was missed for the documentation and non-admin UI endpoints as documented in getting_started

To Reproduce

  1. Run a DOT-using app
  2. Go to http://127.0.0.1:8000/o/applications/register/
  3. Note that there's no clear warning about copying the client_secret before save as there is in the admin UI.

Expected behavior

The user should be warned to copy the secret before save as is done at http://127.0.0.1:8000/admin/oauth2_provider/application/add/

Version

2.2.0

  • I have tested with the latest published release and it's still a problem.
  • I have tested with the master branch and it's still a problem.

Additional context

See #1235 although that issue says the unhashed secret was used so the error may be unrelated.

@n2ygk n2ygk added the bug label Dec 29, 2022
@JordiNeil
Copy link
Contributor

I've been spending couple hours debugging this as I expected it not to be so hard to solve 😵‍💫
And I found that in this ApplicationRegistration view we're not passing the help_texts parameter to the modelform_factory method, then I added it like this just for testing
image
But stills not getting the help text in the response, this time I lost the track at the rendering moment, seems like django.forms.widgets does not handle help_texts 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants