Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed inheritance from object #863

Merged
merged 1 commit into from Sep 15, 2020
Merged

Removed inheritance from object #863

merged 1 commit into from Sep 15, 2020

Conversation

smithdc1
Copy link
Contributor

@smithdc1 smithdc1 commented Sep 8, 2020

A small tidy up -- object is no longer required.

@coveralls
Copy link

coveralls commented Sep 8, 2020 •
edited

Pull Request Test Coverage Report for Build 1438

  • 6 of 6 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.807%
Totals Coverage Status
Change from base Build 1436: 0.0%
Covered Lines: 1439
Relevant Lines: 1534
💛 - Coveralls

n2ygk
n2ygk previously approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@n2ygk n2ygk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks for the cleanup.

@smithdc1 But please rebase.

@n2ygk n2ygk dismissed their stale review September 15, 2020 13:55

requesting rebase

n2ygk
n2ygk requested changes Sep 15, 2020
View reviewed changes
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smithdc1 looks good but please rebase against master.

@smithdc1
Removed inheritance from object
25b5af2 
No longer required with Python 3
@smithdc1
Copy link
Contributor Author

@n2ygk done!

@n2ygk n2ygk merged commit 295c065 into jazzband:master Sep 15, 2020
@smithdc1 smithdc1 deleted the object branch September 15, 2020 18:58
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Closed
@obulat obulat mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smithdc1 @coveralls @n2ygk