Disable 255 chars length limit for redirect uri (#902) #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 7230 recommends to design system to be capable to work with URI at least to 8000 chars long. This commit allows handle redirect_uri that is over 255 chars. Fixes issue jazzband#902.
Pull Request Test Coverage Report for Build 1523
💛 - Coveralls |
MattBlack85
reviewed
Dec 14, 2020
MattBlack85
approved these changes
Dec 16, 2020
|
@shaddeus we need an entry for the CHANGELOG(and your name in AUTHORS if it's not already there) |
|
@MattBlack85 Yes, I'll add an entry into CHANGELOG. |
|
Credit/(blame:-) to all who contribute!
It's why it's in the PR template checklist.
…On Wed, Dec 16, 2020 at 9:33 AM Pavel Tvrdík ***@***.***> wrote:
@MattBlack85 <https://github.com/MattBlack85> Yes, I'll add an entry into
CHANGELOG.
Really? Should I write me to a list of AUTHORS? It would be a honor.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#903 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBHS56OBLSNT7JUDGOVBOLSVDAMDANCNFSM4UWUJ5MQ>
.
|
2 tasks
|
thanks for your contribution @shaddeus ! |
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902
Description of the Change
Changed model field
AbstractGrant.redirect_uri(fromCharField(max_length=255)) toTextField().Added a pytest for
AbstractGrantmodel. Unfortunately it works effective only with database engines that limits strings withVARCHAR(255)data type) - not SQLite. See documentation.Creates
BaseTestModelsclass with a testing user. UsesTestModels,TestCustomModels,TestGrantModel,TestAccessTokenModel,TestRefreshTokenModelandTestClearExpired.Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS