Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop retired Python 3.5 #936

Merged
merged 5 commits into from Mar 10, 2021
Merged

Drop retired Python 3.5 #936

merged 5 commits into from Mar 10, 2021

Conversation

amureki
Copy link
Member

@amureki amureki commented Mar 9, 2021

Description of the Change

Python 3.5 did reach end-of-life in September 2020:
https://www.python.org/downloads/release/python-3510/

We can safely remove it from CI to reduce test running time.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Python 3.5 did reach end-of-life in September 2020:
https://www.python.org/downloads/release/python-3510/

We can safely remove it from CI to reduce test running time.
@amureki amureki self-assigned this Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #936 (4415928) into master (d6d1f99) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #936   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files          30       30           
  Lines        1423     1423           
=======================================
  Hits         1351     1351           
  Misses         72       72           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d1f99...4415928. Read the comment docs.

@amureki
Copy link
Member Author

amureki commented Mar 9, 2021

There is a funny artefact:

build (3.5) Expected — Waiting for status to be reported

I don't think it is coming from code, but rather something was cached or so.

Also, I noticed that GH Actions are running twice, I took an opportunity to fix it in a separate PR: #937

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@n2ygk
Copy link
Member

n2ygk commented Mar 10, 2021

@MattBlack85 @jezdez Do you know how we "unstick" this expected build (3.5)? This PR removes py35. I believe this has to be removed from the protect branch settings.

@jezdez
Copy link
Member

jezdez commented Mar 10, 2021

@jezdez Do you know how we "unstick" this expected build (3.5)? This PR removes py35. I believe this has to be removed from the protect branch settings.

Yeah, no problem, I removed the branch protection for the 3.5 build.

Rust Saiargaliev added 2 commits March 10, 2021 12:43
* origin/master:
  Revert "GitHub Actions: smart run strategy (#937)" (#939)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants