New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop retired Python 3.5 #936
Conversation
Python 3.5 did reach end-of-life in September 2020: https://www.python.org/downloads/release/python-3510/ We can safely remove it from CI to reduce test running time.
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 30 30
Lines 1423 1423
=======================================
Hits 1351 1351
Misses 72 72 Continue to review full report at Codecov.
|
There is a funny artefact:
I don't think it is coming from code, but rather something was cached or so. Also, I noticed that GH Actions are running twice, I took an opportunity to fix it in a separate PR: #937 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@MattBlack85 @jezdez Do you know how we "unstick" this expected build (3.5)? This PR removes py35. I believe this has to be removed from the protect branch settings. |
Yeah, no problem, I removed the branch protection for the 3.5 build. |
Description of the Change
Python 3.5 did reach end-of-life in September 2020:
https://www.python.org/downloads/release/python-3510/
We can safely remove it from CI to reduce test running time.
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS