Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 4.1 support #774

Closed

Conversation

kevinmarsh
Copy link
Contributor

Only a small change was required in the tests to handle this change about removing the type="text/css" attributes for CSS link tags:

2022-09-29_12-14


It might make sense when releasing a new version to drop support for Python 3.6 and Django 2.2, 3.0 and 3.1 since they have all reached end of life. If you want I can push that in this PR or seperately

Fix the `<link>` tag regexes in the tests to reflect the fact
that the `type="text/css"` attribute is no longer rendered
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #774 (0c2821f) into master (c85a257) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #774   +/-   ##
=======================================
  Coverage   80.75%   80.75%           
=======================================
  Files          33       33           
  Lines        1143     1143           
=======================================
  Hits          923      923           
  Misses        220      220           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@exallium
Copy link

From the looks of it, the changeset here only appears to cover test files and workflows, correct? The current version of django-pipelines should still be ok to utilize in a 4.1 project? (Genuine question. I still think this PR is important regardless of the answer!)

@kevinmarsh
Copy link
Contributor Author

Yea we've been using the latest (2.0.8) django-pipeline release with Django 4.1 (on Python 3.10) in production for a couple months and it's been fine (for the narrow case we're using it for). So this PR was just updating the testing matrix and classifiers so the package "officially" supports Django 4.1

@kevinmarsh
Copy link
Contributor Author

Looks like this got released in #786

@kevinmarsh kevinmarsh closed this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants