Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release ? #636

Closed
frallain opened this issue Dec 8, 2021 · 25 comments
Closed

New release ? #636

frallain opened this issue Dec 8, 2021 · 25 comments
Assignees

Comments

@frallain
Copy link

frallain commented Dec 8, 2021

Would it be possible to enjoy a new release of django-push-notifications ? It has been one year and half since no release and I can see several commits the community could benefit from, given that Django 4.0 is out and that the current 2.0.0 release emits the following warnings :

/venv/lib/python3.8/site-packages/push_notifications/models.py:235: RemovedInDjango40Warning: django.utils.translation.ugettext_lazy() is deprecated in favor of django.utils.translation.gettext_lazy().
    verbose_name=_("User public encryption key"),

Thanks for this package, keep up the good work!

@bertonha
Copy link
Contributor

Would be really nice to have a new release because the current released version does not supports Django 4.0.
it raise the following error.

File "push_notifications/admin.py", line 3, in <module>
   from django.utils.encoding import force_text
   
ImportError: cannot import name 'force_text' from 'django.utils.encoding'

@richardthegit
Copy link

Just to add - it also doesn't work with current versions of PyJWT, which make life very difficult when using other packages rely on the new PyJWT API.

@bradleydworak
Copy link

Ditto, code needs updated for compatibility with Django 4.0.
The following conflicting lines:

from django.utils.encoding import force_text
from django.utils.translation import ugettext_lazy as _

should be updated to:

from django.utils.encoding import force_str
from django.utils.translation import gettext_lazy as _

@bigfootjon
Copy link

The required fixes seem to already be present: ff13377

we just need a new release created

@sevdog
Copy link
Contributor

sevdog commented Jan 12, 2022

The force_text was replaced with force_str in ce2140f.

@bradleydworak
Copy link

Thank you @bigfootjon and @sevdog, I concur. We are awaiting a release. Any known issues holding it up?

@gabn88
Copy link

gabn88 commented Jan 20, 2022

@simonkern Would it be possible to create a new release?

@simonkern
Copy link
Contributor

I only opened two or three pull requests, but have no permissions regarding this package.

@gabn88
Copy link

gabn88 commented Jan 20, 2022

@simonkern Thanks for the fast response. Do you know who has? It is a really nice package, and it would be a pity to lose it due to the lack of new releases.

@jamaalscarlett
Copy link
Member

Sorry everyone, I have pypi access

@jamaalscarlett
Copy link
Member

Which commit are we using for the release?

@jamaalscarlett jamaalscarlett self-assigned this Jan 20, 2022
@bigfootjon
Copy link

Latest commit from ‘master’ seems fine to me. It has some missing migrations in it. 4.0 support landed a few commits before that

@jamaalscarlett
Copy link
Member

OK I'll use db0606c

@jamaalscarlett
Copy link
Member

It will be 2.1.0

@daveisfera
Copy link

daveisfera commented Jan 20, 2022

Thanks for getting this out, but if it's not too late, the version number should probably be 3.0.0 since it's dropping support for Django 1.x:
da97ebe#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52R30

@vvxhid
Copy link

vvxhid commented Jan 21, 2022

any updates please ?

@jamaalscarlett
Copy link
Member

@jleclanche could you create this release. Apparently when I restored my phone, it reset my authenticator app so I am currently locked out of pypi

@jleclanche
Copy link
Member

@jamaalscarlett I don't feel comfortable doing the release myself, but I can approve anyone who's stepping up to do it. This is a jazzband project after all.

@bradleydworak
Copy link

@jleclanche and @jamaalscarlett Is there something in particular about not feeling comfortable with a new release? Not clear what the hold up is.

@jleclanche
Copy link
Member

@bradleydworak I don't feel comfortable doing a release on this project because I haven't done one in years and I don't use the library anymore to test it / know if it's ready for a release.

@bertonha
Copy link
Contributor

bertonha commented Feb 7, 2022

@jleclanche I am using the latest master for a while, and its sending push-notifications to IOS and Android.

The current version 2.0.0 does not support Django 4.0 which is a blocker for many people. and a new release would unblock it.

@jleclanche
Copy link
Member

Again: If another jazzband member wants to step up to do the release, I can give permissions. @jamaalscarlett I can also add whatever account of yours you need. But I am not comfortable doing it myself.

@daveisfera
Copy link

Could the version be bumped to 3.0 and it released? That would be lower risk since people shouldn't be hit with the package upgrading under them and then more testing can happen for those that are ready to make the upgrade.

@jamaalscarlett
Copy link
Member

My pypi account was finally unlocked, so I can create the release 3.0.0 using commit 6fde730 tomorrow, unless there are any objections

@jamaalscarlett
Copy link
Member

Sorry about the delay everyone
https://github.com/jazzband/django-push-notifications/releases/tag/3.0.0
https://pypi.org/manage/project/django-push-notifications/release/3.0.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests