Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated dependency on apns2 and use aioapns instead? #646

Closed
gabn88 opened this issue Jan 20, 2022 · 3 comments
Closed

Remove outdated dependency on apns2 and use aioapns instead? #646

gabn88 opened this issue Jan 20, 2022 · 3 comments

Comments

@gabn88
Copy link

gabn88 commented Jan 20, 2022

The history:

apns2 is used for communicating with Apple for push notifications (APN). It depends on hyper, which is unmaintained (see here: Pr0Ger/PyAPNs2#126 (comment)).

The problem:

apns2 uses an old version of py-jwt for this communication and is also sort of unmaintained. For example djangorestframework-simplejwt (and probably other packages) use a newer version of py-jwt.

A half-baked solution:

Install apns2 manually from master (pip install --upgrade git+https://github.com/pr0Ger/PyAPNs2.git@5e4a938)

A better solution/proposal:

Change dependency from apns2 to aioapns, since the latter seems to be the better maintained package ( see Pr0Ger/PyAPNs2#126 (comment), from @erwan-lemmonier )

What do you think?

@jamaalscarlett
Copy link
Member

Makes sense to me, if we can get a PR and all the tests still pass. But I only use android/web so I'll differ to others.

@Theunis111
Copy link

Are you able to retrieve the registration ID with aioapns? I am really struggling to retrieve the id of ios devices, keep getting bad device token and cant see the id at all.

@azmeuk
Copy link
Member

azmeuk commented Aug 18, 2023

Closing in favor of #622

@azmeuk azmeuk closed this as completed Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants