timeout=None in django 1.6

[rmmr]

Just noticed and by looking at the master, django-redis does not fully support django 1.6 . Previously, passing None explicitly would use the default timeout value. Now it will cache the value forever. This change was made in order to allow timeout = 0 to let the cache expire immediately. I'll most likely make a fork, cause I need this badly.

[niwinz]

Making this change is dangerous, because, previously, the permanent cache is done by setting timeout to 0 and a new version just do the opposite behavior. All behavior that are now supported on django 1.6, are already supported much earlier in django-redis.

I don't know the good way to change this mantaining backward compatibility.

[rmmr]

I think it's quite simple. Check the django version and use a settings.py entry. For 1.6 and up switch to the behaviour as documented in django 1.6. This means timeout = 0 will not cache indefinitely for django 1.6 users. If by any chance 1.6 users will want to keep the old behaviour, they can change the settings.py entry.

It's dangerous not to make any change, because 1.6 users who want to switch from django's default caching backends to yours can run into trouble.

I'll work this out in my fork anyways. Cheers!

[niwinz]

Great! Thanks!

[rmmr]

Allright, made an initial attempt to fix this. Changes can be found in client/default.py at lines 32 and 140 - 145. Changes should be self-explanatory.

[niwinz]

Sorry, but I don't have much time this week for it. This weekend this should be merged and fixed!

[niwinz]

Now partially merged with minor changes: 09939dc

Backward compatibility changes are not necessary, because 0 immediate timeout is only for memcached backend and django-redis can continue with own behavior :D

Thanks for your efforts!

[rmmr]

Thank you too! Even better :) who needs immediate timeouts anyway.