Quality of life improvements in Requests tab

[glujan]

I'm using you're package quite often and wanted to give something back to this project 😄

This PR focuses on improving experience on Request tab - one improvement per commit:

• Add message when there are no requests to display: when there are no matches instead of displaying an empty page, let user know that there are no filter results
• Add 'Clear all filters' button - when user fills in a few filters, clearing them is rather tedious task so I thought it would be nice to have a button to clear filters.
• Add small margin for filter selects: I think this change makes filter section looks much better.

This branch is based off 4.2.0 tag, please let me know if I need to rebase.

[auvipy]

thank your for your contributions, lets see what the CI says :D

[codecov]

Codecov Report

Merging #537 (6d8204e) into master (8f8d159) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #537   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files          51       51           
  Lines        2058     2058           
=======================================
  Hits         1741     1741           
  Misses        317      317           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8d159...6d8204e. Read the comment docs.

[auvipy]

can you please share the screenshots of UI that changed with this PR?

[glujan]

Updated filters:

New message saying there are no matching results:

Changes not included in this PR

I also have some other changes to CSS which makes text inputs in filters easier to see (some of my colleagues did not notice that you can use filters like Executed n seconds ago). I can include those changes in the PR if you like it but of course for me it's fine to keep it as overrides in my project(s):

[auvipy]

you can add the other improvements to this PR

[glujan]

@auvipy I've added those additional changes, the PR is good to be reviewed now.

[albertyw]

Looks good to me too. Thanks!

[auvipy]

This branch is based off 4.2.0 tag, please let me know if I need to rebase.

that should target main branch

[glujan]

PR was already targeting master branch, but now my branch is rebased against master branch.

[auvipy]

btw, should'nt we mention the UI changes in the docs where necessary?

[glujan]

btw, should'nt we mention the UI changes in the docs where necessary?

@auvipy I can add some docs regarding what has changed but I cannot see any section about filtering in the docs. Could you point me where I should add it?

There is also a changelog file, should I update it or will it be updated when creating a new release?

[glujan]

Hi @auvipy , should I do anything more to get this merged? I'm happy to improve this PR to meet your - and the whole Jazz Band's - expectations!

[albertyw]

There's some docs under https://github.com/jazzband/django-silk/tree/master/docs/ which could be updated but none of them are invalidated by this change so I'll merge this as is.