Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignore_conflicts parameter in bulk_create_with_history #732

Closed
shihanng opened this issue Nov 5, 2020 · 0 comments · Fixed by #733
Closed

Support ignore_conflicts parameter in bulk_create_with_history #732

shihanng opened this issue Nov 5, 2020 · 0 comments · Fixed by #733

Comments

@shihanng
Copy link
Contributor

shihanng commented Nov 5, 2020

Problem Statement
Django 2.2 includes ignore_conflicts parameter into bulk_create(). Would it be possible for django-simple-history to allow the same parameter to be passed into bulk_create_with_history()?

Documentation: https://docs.djangoproject.com/en/2.2/ref/models/querysets/#django.db.models.query.QuerySet.bulk_create

Describe the solution you'd like
Update bulk_create_with_history() with following signature:

def bulk_create_with_history(
    objs,
    model,
    batch_size=None,
    ignore_conflicts=False,
    default_user=None,
    default_change_reason=None,
    default_date=None,
):

Describe alternatives you've considered
N/A

Additional context
N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant