Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Django 4.0? #940

Closed
pallavg opened this issue Jan 11, 2022 · 3 comments
Closed

Compatibility with Django 4.0? #940

pallavg opened this issue Jan 11, 2022 · 3 comments

Comments

@pallavg
Copy link

pallavg commented Jan 11, 2022

Problem Statement
I have used this excellent plugin before in Django 3.1/3.2. It works without any issues. However, when I tried running it on Django 4.0, I got some errors. Looks like there are some API changes in Django 4.0. For example, "The providing_args argument for django.dispatch.Signal is removed.". See https://docs.djangoproject.com/en/4.0/releases/4.0/. There might be others but since I'm not a library developer, I'm not sure.

Describe the solution you'd like
Please support this plugin on Django 4.0.

Describe alternatives you've considered
I don't have one as this plugin is excellent.

Additional context
None.

@SAbimhamed
Copy link

I am facing the following issue:
File "/Users/...../Library/Python/3.8/lib/python/site-packages/django/db/models/fields/init.py", line 1086, in decons
truct
if self.db_collation:
AttributeError: 'CountryField' object has no attribute 'db_collation'

@jeking3
Copy link
Contributor

jeking3 commented Jan 12, 2022

@pallavg The CI tests are failing against django's main branch but they are passing against the 4.0 release. That issue still needs to be resolved but otherwise we have no known issues with Django 4.0 at the moment. I see no mention in this codebase of providing_args. What's on main works with django 4.0, as I use it in a production site.

@SAbimhamed self.db_collation is not present anywhere in this codebase. The only place I could find is in models.py:transform_field where we set a field's db_collation attribute to None. However, this does not align with what you reported.

@jeking3 jeking3 closed this as completed Jan 18, 2022
@zahidmian
Copy link

@jeking3 I have the same issue (unexpected keyword argument 'providing_args') with Django 4.0. It's because conda-forge package is not updated with the latest version. Can this be updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants