Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time for a new release? #960

Closed
1ace opened this issue Mar 2, 2022 · 20 comments · Fixed by #979
Closed

Time for a new release? #960

1ace opened this issue Mar 2, 2022 · 20 comments · Fixed by #979

Comments

@1ace
Copy link

1ace commented Mar 2, 2022

It's been a while since 3.0.0 and a lot has been done. Is it time for 3.1.0/4.0.0?

In my case, I need #866, and I'm finding myself installing git+https://github.com/jazzband/django-simple-history#master to be able to use it.

@brendanbrett
Copy link

I am also eagerly awaiting a new release, specifically for #866! I hope the great work done by @jeking3 can be reviewed and incorporated soon.

@1ace
Copy link
Author

1ace commented Mar 11, 2022

Pinging @barm who did the last release, and @rossmechanic who did pretty much all the releases before that 🙂

@jeking3
Copy link
Contributor

jeking3 commented Mar 14, 2022

Thanks for the kind words. I would really like to see #941 get in as well, which builds on top of #866. I don't mind attempting to drive a release but I have been waiting for an approval on that one for two months.

@lazarust
Copy link

Getting #941 and #932 merged in and released would be really great for me! They both have features that I'm really needing.

@utapyngo
Copy link
Member

utapyngo commented Mar 23, 2022

Can we release them separately?
#941 is already in.

@lazarust
Copy link

That would be fine with me! I just don't want #932 to be forgotten.

@utapyngo
Copy link
Member

Pinging @barm who did the last release, and @rossmechanic who did pretty much all the releases before that.

@barm
Copy link
Collaborator

barm commented Mar 30, 2022

Hey all, sorry for the radio silence. I should be able to help cut a release this week.

@lazarust
Copy link

lazarust commented Apr 5, 2022

@barm Any update on when you think you'd be able to make that release?

@jeking3
Copy link
Contributor

jeking3 commented Apr 9, 2022

Review and approve, if you could: update CHANGES to prepare for 3.1.0

@jeking3
Copy link
Contributor

jeking3 commented Apr 11, 2022

https://github.com/jazzband/django-simple-history/releases/tag/3.1.0

As far as I know, apart from dropping Django 2.2, 3.1, Python 3.6 - this is compatible with 3.0.0. There was a change around the as_of call that now returns a filtered QuerySet instead of a list of results. The documentation for as_of explicitly stated that the return value was an Iterable. This has not changed. Both list[] and QuerySet are iterable. Therefore I tagged this as a pre-release for 3.1.0 and we'll see what happens. The alternative is to make it a 4.0.0 release.

@areski
Copy link
Contributor

areski commented Apr 13, 2022

I'm unable to install that release, I'm getting an error with LookupError: setuptools-scm was unable to detect version
full error: https://pastebin.com/sdws9zJp

Maybe that would be a possible solution: pypa/setuptools_scm#536
Anybody else having the same issue?

On a side note, we might want to update https://github.com/jazzband/django-simple-history/blob/master/pyproject.toml#L7 as it's referring to Python 3.6 which would be now unsupported.

@utapyngo
Copy link
Member

When will there be a release to PyPI?

@jeking3
Copy link
Contributor

jeking3 commented Apr 22, 2022

I will re-tag and re-spin the v3.1.0 pre-release after that PR passes and gets merged. I think we need to remove the v3.1.0 pre-release indicator for them to consider publishing it to pypi, but I'm not sure...

@jeking3
Copy link
Contributor

jeking3 commented Apr 22, 2022

Could someone please approve #978

@jeking3
Copy link
Contributor

jeking3 commented Apr 23, 2022

Okay I updated the 3.1.0 tag and made another pre-release. It fixes both the issues found above.

@jeking3
Copy link
Contributor

jeking3 commented Apr 23, 2022

jazzband/help#283

@jeking3
Copy link
Contributor

jeking3 commented Apr 23, 2022

I'm going to put the tag back on 3.1.0 and spin a 3.1.1 release with these fixes, then the roadies can move it up to pypi.

@jeking3
Copy link
Contributor

jeking3 commented Apr 23, 2022

Note: 3.1.0 and 3.1.1 are now in the roadies' hands to get up to pypi.

@lazarust
Copy link

lazarust commented May 6, 2022

Any updates on getting this release onto pypi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants