Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and move doc/changelog.txt to CHANGELOG.txt. Modify MANIFESTin #120

Merged
merged 3 commits into from Mar 25, 2013

Conversation

rihoward
Copy link
Contributor

Rename and move doc/changelog.txt to CHANGELOG.txt. Modify MANIFESTin
so that additional files such as LICENSE, AUTHOR etc will be packaged. Needed to comply with rpm packaging standards.

… so additional files such as LICENSE, AUTHOR etc will be packaged.
@@ -1,2 +1,6 @@
include LICENSE
include CHANGELOG.txt
include AUTHOR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's AUTHORS

@rihoward
Copy link
Contributor Author

corrected AUTHOR to AUTHORS in commit 9021fae

@apollo13
Copy link
Contributor

The changelog is still included in https://github.com/alex/django-taggit/blob/master/docs/index.txt#L20 -- It would be nice to have the changelog in the docs too, is there any way to tell sphinx to the toplevel file?

@rihoward
Copy link
Contributor Author

Doesn't the recursive-include docs *.txt line in MANIFEST.in do that?

@apollo13
Copy link
Contributor

Yes, for the source tarball, but it would be nice to have the changelog in the rendered html pages too

@rihoward
Copy link
Contributor Author

Would a symbolic link from CHANGELOG.txt ---> docs/CHANGELOG.txt work?

@apollo13
Copy link
Contributor

Not on windows I fear ;)

@rihoward
Copy link
Contributor Author

Is windows an OS or a gaming platform ;)

@rihoward
Copy link
Contributor Author

I guess we would need 2 copies of the file

@apollo13
Copy link
Contributor

Well since taggit is pure python there is no reason not to support it…

@apollo13
Copy link
Contributor

@rihoward
Copy link
Contributor Author

Any suggestion is welcome but I need to go out now. It is ~10:30 AM PST here. I can look at this tonight

@apollo13
Copy link
Contributor

No hurry :) Thx for looking into it.

@rihoward
Copy link
Contributor Author

Well I need django-taggit for a project I am helping on and we need to distribute it as an RPM. One of those situations were the install site will not have connections to internet. Hence need to supply as a common format for the OS.

@apollo13 apollo13 merged commit 1eae045 into jazzband:master Mar 25, 2013
@apollo13
Copy link
Contributor

Fixed and merged, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants