Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI Release: django-dbtemplates #309

Closed
mpasternak opened this issue Aug 15, 2022 · 8 comments
Closed

PyPI Release: django-dbtemplates #309

mpasternak opened this issue Aug 15, 2022 · 8 comments
Labels

Comments

@mpasternak
Copy link

PyPI Release

I'd like to make a release of django-dbtemplates, I'm the project lead, but I don't think I have PyPI privs, my login there is the same as here on GitHub. Thanks!

@jezdez
Copy link
Member

jezdez commented Aug 15, 2022

@mpasternak Please read the docs about releases, this is essential as a project lead (just like any other documentation on jazzband.co).

In short: You won't be provided PyPI permissions, but Jazzband releases happen to the Jazzband staging index on jazzband.co, where project leads can verify and confirm them before they are pushed to PyPI. The way project leads are informed of a release is by email to their email address verified by GitHub. The email contains additional information about each release and the changes since the last release should be verified and confirmed to prevent malicious releases.

Please make sure that all code changes are done before you the git tag to trigger the release workflow, e.g. so changelog updates, version specifier updates etc. I hope that helps!

@mpasternak
Copy link
Author

I've tagged it and I've received the e-mail. What do we do next, do you have some time to spare and are you willing to review the release or should I be the person to click the "release" link? thanks.

@jezdez
Copy link
Member

jezdez commented Aug 29, 2022

I've tagged it and I've received the e-mail. What do we do next, do you have some time to spare and are you willing to review the release or should I be the person to click the "release" link? thanks.

Usually in projects with multiple leads it's up to them to figure this out, and I'm happy to delegate this to you in this case, I've looked at the commits and found them reasonable.

Only minor nit is that the tag is using SemVer style 4.0.0 while the past releases were all without additional patch version, e.g. 3.0. Would be great if you could redo the tag and release it as 4.0, but it's also not a dealbreaker.

@mpasternak
Copy link
Author

I've tagged it 4.0, why not.

I noticed you use use_scm_version in setup.py and that the version number actually does not appear anywhere along the source. I understand that this is the part of the workflow and that's okay. How can you get the package version number if you use use_scm_version for it? pkgtools? I'm just wondering if I could use it in my workflows, I use CalVer scheme for now.

@mpasternak
Copy link
Author

I seem to have received the mail about the WHL file twice, perhaps once as a member and once as a leader. Do you have that workflow mailing code somewhere? Maybe I could patch it?

@hugovk
Copy link
Member

hugovk commented Aug 30, 2022

I noticed you use use_scm_version in setup.py and that the version number actually does not appear anywhere along the source. I understand that this is the part of the workflow and that's okay. How can you get the package version number if you use use_scm_version for it? pkgtools? I'm just wondering if I could use it in my workflows, I use CalVer scheme for now.

use_scm_version is used by https://github.com/pypa/setuptools_scm (also mentioned in setup.py) to automatically set the package version from the Git tag. No need to hardcode the version in setup.py.

I seem to have received the mail about the WHL file twice, perhaps once as a member and once as a leader. Do you have that workflow mailing code somewhere? Maybe I could patch it?

It's in https://github.com/jazzband/website, looks like https://github.com/jazzband/website/blob/main/jazzband/projects/tasks.py is a good place to start.

@mpasternak
Copy link
Author

@hugovk thanks, @jezdez already had an issue with that problem jazzband/website#491 , here's my attempt jazzband/website#1030

@jezdez
Copy link
Member

jezdez commented Sep 5, 2022

This was done recently, closing.

@jezdez jezdez closed this as completed Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants