Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for non valid strings #70

Closed
wants to merge 1 commit into from
Closed

Add test for non valid strings #70

wants to merge 1 commit into from

Conversation

uriva
Copy link

@uriva uriva commented Nov 25, 2018

No description provided.

@coveralls
Copy link

coveralls commented Nov 25, 2018

Pull Request Test Coverage Report for Build 109

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 107: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

@jaraco
Copy link
Owner

jaraco commented Nov 26, 2018

This is interesting. In particular, it's interesting that the tests pass on Python 3.6 and 3.7, but not older versions. I'm curious to know why the error only happens on older Pythons.

I'm not sure this kind of test belongs in that file - I've always imagined that file to represent the canonical usage, not abbarant usage. I think I'd prefer for tests like these to be captured separately, probably through a separate unit test, maybe parameterized.

@jaraco jaraco closed this Apr 19, 2019
jaraco added a commit that referenced this pull request May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants