New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.7 and drop 3.4 #347
Conversation
@hugovk Can you please resolve conflicts. I have requested a review of @kenneth-reitz and @timofurrer. Thanks |
That's something Kenneth has to approve. |
Python 3.4's EOL is 2019-03-16: |
What about rebasing and squashing commits for a cleaner history? |
That's fine. Thanks. We still need BDFL approval in order to merge that. Thanks for your patience! 🎉 |
The repo has now been transferred to @vinayak-mehta. @vinayak-mehta Is this okay to merge? It's had three approvals so far. Thanks! |
Could you please rebase the branch? |
Rebased! Dropped the changes to requirements.txt, they've been dealt with in master. |
Awesome, thanks! |
You're welcome! And thanks for the review and merge! |
Some dependencies need updating to support Python 3.7, including pandas.
There's no release of pandas which supports both 3.4 and 3.7.
So let's drop 3.4, it's very nearly EOL, on 2019-03-16.
https://en.wikipedia.org/wiki/CPython#Version_history