Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.7 and drop 3.4 #347

Merged
merged 4 commits into from Oct 3, 2019
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 14, 2019

Some dependencies need updating to support Python 3.7, including pandas.

There's no release of pandas which supports both 3.4 and 3.7.

So let's drop 3.4, it's very nearly EOL, on 2019-03-16.

https://en.wikipedia.org/wiki/CPython#Version_history

@ParthS007
Copy link
Contributor

@hugovk Can you please resolve conflicts. I have requested a review of @kenneth-reitz and @timofurrer.

Thanks

@timofurrer
Copy link
Member

That's something Kenneth has to approve.
I'd wait for EOL - 3.4.10. See https://www.python.org/dev/peps/pep-0429/#id4

@hugovk
Copy link
Member Author

hugovk commented Mar 2, 2019

Python 3.4's EOL is 2019-03-16:

docs/intro.rst Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@claudep
Copy link
Contributor

claudep commented Mar 9, 2019

What about rebasing and squashing commits for a cleaner history?

@hugovk
Copy link
Member Author

hugovk commented Mar 9, 2019

OK, rebased to drop the merge commits.

If you want them as a single commit, you can use the Squash and merge option:

@timofurrer
Copy link
Member

That's fine. Thanks.

We still need BDFL approval in order to merge that. Thanks for your patience!

🎉

@hugovk
Copy link
Member Author

hugovk commented Aug 7, 2019

The repo has now been transferred to @vinayak-mehta.

@vinayak-mehta Is this okay to merge? It's had three approvals so far. Thanks!

.travis.yml Outdated Show resolved Hide resolved
@claudep
Copy link
Contributor

claudep commented Oct 3, 2019

Could you please rebase the branch?

@hugovk
Copy link
Member Author

hugovk commented Oct 3, 2019

Rebased!

Dropped the changes to requirements.txt, they've been dealt with in master.

@claudep claudep merged commit 923711d into jazzband:master Oct 3, 2019
@claudep
Copy link
Contributor

claudep commented Oct 3, 2019

Awesome, thanks!

@hugovk
Copy link
Member Author

hugovk commented Oct 3, 2019

You're welcome! And thanks for the review and merge!

@hugovk hugovk deleted the add-3.7 branch October 3, 2019 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants