Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't update a field #54

Closed
harmv opened this issue Feb 8, 2012 · 3 comments
Closed

Can't update a field #54

harmv opened this issue Feb 8, 2012 · 3 comments

Comments

@harmv
Copy link

harmv commented Feb 8, 2012

Updating a field fails silently.
It should either work, or fail loudly

how to reproduce

import tablib

headers = ('h1', 'h2')
data = tablib.Dataset(headers=headers)
data.append(('foo', 'bar'))
data.append(('foo2', 'bar2'))

data['h1'][1] = 'new'   # update a single cell
assert data['h1'][1] == 'new', "error still contains %s" % data['h1'][1]

result

The update does not barf, but doesn't work either.

Traceback (most recent call last):
File "test.py", line 10, in
assert data['h1'][1] == 'new', "error still contains %s" % data['h1'][1]
AssertionError: error still contains foo2'''

expected result

cell is updated or tablib refuses the assignment.

@slestak
Copy link

slestak commented Sep 6, 2012

Data rows are tuples, so they are immutable. I do not see anything in that docs that state that updating cells is a feature. We can add rows or columns, but modifying a row or column is not currently there.

@kennethreitz
Copy link
Contributor

This project is in a bit of a crisis state — it's really useful, and I use regularly. However, I wrote it several years ago and haven't touched it since. In order to get the project into a stable state I'm closing all issues and pull requests to get a "fresh slate"

Don't take this as aggressive — it's just necessary for the project to make any progress any time soon (it's pretty clear the project is effectively unmaintained at the moment). Great things to come! Please watch the GitHub logs and feel free to re-open this discussion soon. I just need to really it into a good state first.

✨ ❤️ ✨

@jleclanche
Copy link
Member

Would love to see a Dataset.update() API of sorts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants