Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select_room example should keep the room name in the input field #52

Closed
b3aribeiro opened this issue Feb 3, 2022 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request examples this is related to official examples

Comments

@b3aribeiro
Copy link

This feature request is related to the "Is it possible to create multiple rooms through the use of entry keys?" discussion thread:

What currently happens:
The experimental example, select_room, is currently refreshing the HTML input field back to "main" once the user clicks in the "Join Room" button.

What should happen:
After typing the custom room name into the HTML input field and clicking "Join Room", the typed name should remain exposed in the input field, so the users can remember/share their key to friends.

@jbakse jbakse added enhancement New feature or request examples this is related to official examples labels Feb 3, 2022
@jbakse jbakse changed the title P5 select_room example should keep the room key in the input field select_room example should keep the room name in the input field Feb 3, 2022
@jbakse
Copy link
Owner

jbakse commented Feb 3, 2022

Yes, this would be a good addition.

@jbakse
Copy link
Owner

jbakse commented Apr 15, 2022

fixed in 5a54c0d

@jbakse jbakse closed this as completed Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request examples this is related to official examples
Projects
None yet
Development

No branches or pull requests

2 participants