Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External library name is always jbang #45

Closed
nandorholozsnyak opened this issue Mar 14, 2022 · 5 comments
Closed

External library name is always jbang #45

nandorholozsnyak opened this issue Mar 14, 2022 · 5 comments

Comments

@nandorholozsnyak
Copy link
Contributor

After the jbang script is being syncronized it has the name jbang for the dependency collector thing, but if a multi module project is being used it could be a bit "annoying", is there any way to append the name of the module as a prefix for the dependency collector?

Original:
image

Idea:
image

@maxandersen
Copy link
Contributor

would it not be more right to name it after the root file the classpath library was made?

@nandorholozsnyak
Copy link
Contributor Author

would it not be more right to name it after the root file the classpath library was made?

So you say if it has three files for example, App.java, AnotherApp.java and forexmaple TestApp.java, then should it be called App-jbang? It can work yeah, but what about the AnotherApp.java or maybe it could be named after the folder that contains all the files.

For me the module's name make sense to use, but I can imagine that it could/should be configurable. One module/folder can have multiple JBang scripts (depends on the use cases of course), so with that in my how would you infer that name?

@linux-china
Copy link
Contributor

Closed by 0.18.0

@maxandersen
Copy link
Contributor

Fixed how @linux-china ?

@maxandersen
Copy link
Contributor

Ah it was done some weeks ago. Was looking for recent PRs and couldn't find jt :)

Still thinks this should be named per source file rather than per module but current behavior works for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants