New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial responsive version #194
Conversation
Sorry but this doesn't work. If you run this with
There is no sample for the responsive layout or instructions on how to use it. |
i did a quick fix. that was an easy one. should be working now. its still not perfect but i think you'll get an idea |
Is this working? |
@alc32 mostly ? i think it can be improve but it works. |
Why this haven't merged yet? |
Will this pr be merged anytime soon in the nearest future? |
It wasn't working when I first tried it, I didn't check it after the fix. I hope to have some free time to work on it during the next few weeks. |
i have noticed one bug if you add an item on one layout it will not appear on layouts you have already been on.
|
Any update on this? |
had no time to look into the bug @bensladden mentioned. will try as soon as possible |
I added a comment where the bug is with a fix please have a review. The rest seems to work fine. |
@MLongz i'm sorry but where did you comment ? |
It's seems the comment is pending. Its in new_responsiveutils.js at line 97. This seems to fix the bug where gridItem didnt got copied over to the other breakpoints.
But probably have to add a function to Check latest valid item and not last of array. Since you can remove items from array. |
@MLongz thank you for your help. i fixed it differently but i think it should work |
my try for including responsive features.
please look into it and give feedback