Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScoreFunction#isExact is redundant with ExactScoreFunction #293

Closed
rickjamesthe6th opened this issue Apr 16, 2024 · 1 comment
Closed

ScoreFunction#isExact is redundant with ExactScoreFunction #293

rickjamesthe6th opened this issue Apr 16, 2024 · 1 comment

Comments

@rickjamesthe6th
Copy link

Ie, an instanceof ExactScoreFunction would suffice as well. Minor.
@jbellis
Copy link
Owner

jbellis commented Apr 16, 2024

Not entirely sure how this ends up evolving (initially I thought it would be useful to have user-defined subclasses, but that seems mistaken) but for now I prefer isExact() stylistically.

@jbellis jbellis closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbellis @rickjamesthe6th