Fix tor onion string conversion #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed Tor onion multiaddr protocol size spec to 96 bits not 80 because 16 bits are for the port number - added onion protocol case to addressBytesToString - added an onion test to TestStringToBytes to test that multiaddr to string conversion is correct
|
See discussion on similar PR: #21 |
|
Don't forget the protocols.csv :-) then we're equivalent. |
|
please see my comments in
|
|
then merge #21 and we're done with this conversation and we can gradually move on to discussing the more interesting parts of the Tor integration |
|
Thanks very much for this, and for hashing out this stuff. great to hear Tor's port is part of the addr, that it's always a stream, and that it works without a TCP stack. I will merge #21 |
|
This has been addressed in #21 -- thank you very much for championing this, @david415 @ianopolous |
marten-seemann
pushed a commit
to marten-seemann/go-multiaddr
that referenced
this pull request
Feb 25, 2021
…github.com/libp2p/go-maddr-filter-0.0.5 Bump github.com/libp2p/go-maddr-filter from 0.0.4 to 0.0.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added code for onion multiaddr string conversion; added a unit test as well. please review.