Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent double encoding of pagedown option object literal #40

Closed
jberger opened this issue Oct 4, 2014 · 0 comments
Closed

Prevent double encoding of pagedown option object literal #40

jberger opened this issue Oct 4, 2014 · 0 comments

Comments

@jberger
Copy link
Owner

jberger commented Oct 4, 2014

If Mojolicious adds a encode_json_text, then it really should be used here https://github.com/jberger/Galileo/blob/master/lib/Galileo/Page.pm#L42

otherwise something like

helper javascript_literal => sub { Mojo::Util::decode 'UTF-8', encode_json(pop) }

would work too bug involve an unnecessary encoding round-trip

@jberger jberger changed the title Use encode_json_text when released Prevent double encoding of pagedown option obect literal Oct 4, 2014
@jberger jberger changed the title Prevent double encoding of pagedown option obect literal Prevent double encoding of pagedown option object literal Oct 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant