Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Masking Div on Cells #202

Closed
jbetancur opened this issue Aug 12, 2019 · 1 comment · Fixed by #203
Closed

Remove Masking Div on Cells #202

jbetancur opened this issue Aug 12, 2019 · 1 comment · Fixed by #203
Assignees
@jbetancur
Labels
enhancement New feature or request

Comments

@jbetancur
Copy link
Owner

Originally, in order to support row clicking actions, a masking div was provided on each TableCell so that click events could be allowed/ignored. In other words, this was required to make column.ignoreRowClick and column.button work when placing clickable elements in a column.cell.

This side effect here is that you cannot select the content in cells. Additionally, having the masking div makes the code harder to understand and arguably adds overhead to each TableCell rendered. I did notice a very small performance increase after removing the masking div, but I highly doubt it would be perceivable.
@jbetancur jbetancur added the enhancement New feature or request label Aug 12, 2019
@jbetancur jbetancur self-assigned this Aug 12, 2019
@jbetancur
Copy link
Owner Author

Related to #187

@jbetancur jbetancur mentioned this issue Aug 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbetancur jbetancur

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow row context selection - remove masking div jbetancur/react-data-table-component
1 participant
@jbetancur