Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not highlight selected row when "striped rows" is selected #521

Closed
MrAkblt opened this issue Apr 6, 2020 · 7 comments
Closed

Can not highlight selected row when "striped rows" is selected #521

MrAkblt opened this issue Apr 6, 2020 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@MrAkblt
Copy link

MrAkblt commented Apr 6, 2020

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://jbetancur.github.io/react-data-table-component/?path=/story/general--kitchen-sink
  2. Select highlight selected rows and striped rows
  3. Select dark row
  4. See not highlighted
@jbetancur
Copy link
Owner

I am unable to reproduce this. It may be that the color may not be contrasting well on your screen or perhaps this is cross-browser related? But I have no idea what browser you are using.

It's challenging to help without more detail:

https://github.com/jbetancur/react-data-table-component/blob/master/.github/ISSUE_TEMPLATE/bug_report.md

@MrAkblt
Copy link
Author

MrAkblt commented Apr 6, 2020

Sorry for missing detail
OS: Manjaro (Arch)
Browser: Chromium 80.0.3987.149 Arch Linux, Mozilla Firefox 74.0

As seen in the picture, the first selected line is not obvious.

React-data-table

@jbetancur
Copy link
Owner

No problem!

I thought you meant the highlight on hover.

The rows will not highlight on checkbox selection regardless of striping because that feature does not yet exist. It is a feature I have been meaning to add though.

@MrAkblt
Copy link
Author

MrAkblt commented Apr 7, 2020

Well, thanks for the quick response. Good luck with.

@jbetancur
Copy link
Owner

jbetancur commented Apr 13, 2020

@MrAkblt I totally misunderstood you - it's been a long week. You are correct, this is in fact a styling bug where the striped rows are taking precedence over the selected row highlight. I'll put this in for a 6.7.0 or a 6.7.1 release soon.

@jbetancur jbetancur self-assigned this Apr 13, 2020
@jbetancur jbetancur added the bug Something isn't working label Apr 13, 2020
@jbetancur
Copy link
Owner

@MrAkblt this is now fixed in 6.7.0

@MrAkblt
Copy link
Author

MrAkblt commented Apr 28, 2020

I have just noticed your comment @jbetancur , thanks for your fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants