Bug in Mono.Cecil.Cil.VariableDefinitionCollection

[KrisVandermotten]

When calling RemoveAt on Mono.Cecil.Cil.VariableDefinitionCollection, which is inherited from Collection, the variable indices are wrong.

The reason is that Collection::RemoveAt calls Collection::OnRemove before actually removing the item.
As a result, VariableDefinitionCollection::OnRemove calls ComputeIndexes() before the item is actually removed.
As a result, the call to VariableDefinitionCollection::ComputeIndexes() has no effect.

[KrisVandermotten]

It looks like ParameterDefinitionCollection may have the same problem.

It looks like the Collection::Remove(T) method also causes the problem, and that a fix in both methods would be to move the call to OnRemove after the Shift/Clear/version block.

[jbevain]

Fixed, thanks.