Default stack size in PE file header changes after writing new assembly

[arelath]

I noticed this when using fody to rewrite a .net assembly. The assembly was compiled for x64 only. The default stack size is 4MB when targeting x64, but 1 MB otherwise. After rewriting the assemebly, the default stack size changed from 4MB to 1MB. I only noticed this because after using fody to rewrite an assembly, I started getting stack overflow errors.

This information is stored in the PE header of the executable. You can verify and test this using dumpbin (command line utility that comes with visual studio). The command "dumpbin /headers file.exe" will show you the default stack size. You can edit the default stack size using the command "editbin /stack:newsize file.exe"

I assume this is actually a cecil bug and not fody directly since it looks like fody is just using cecil on the back end to rewrite the assembly. If this is really a fody implementation bug, let me know and I'll move it over there.

[jbevain]

Thanks for reporting this. That looks like an easy fix, do you want to give it a try?

[arelath]

If you have a fix, I'll be happy to test it. It would be nice to remove our workaround for stack size.

[jbevain]

I mean to you feel like submitting a PR to fix this?