-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle user attributes of type list #74
Comments
I have created a pull request Please let me know if this looks ok. |
@tarunpaul thanks! I've taken a quick look and the PR is missing a test. I'd say that the for loop you created overwrites the attribute.text with the last value of the list. A test would prove me wrong ;) Could you please add the test? |
@manelclos I have added a test case. Please take a look. |
Hi @manelclos, Please let me know if this looks ok or if I have missed anything. $ python3 runtest.py |
@tarunpaul just checked the code locally, all good! Let's see if @jbittel has some time to approve it. |
Great! |
Merged. Much appreciated! |
The ValidationResponse should handle list attributes.
https://apereo.github.io/cas/4.2.x/protocol/CAS-Protocol-Specification.html#257-example-response-with-custom-attributes
"affiliation" : [ "staff", "faculty" ]
Should translate to
The text was updated successfully, but these errors were encountered: