Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #196 exception in MyST/markdown-it-py #197

Merged
merged 1 commit into from Jan 4, 2023
Merged

Fix #196 exception in MyST/markdown-it-py #197

merged 1 commit into from Jan 4, 2023

Conversation

matthias-colt
Copy link
Contributor

For the markdown_it module used by myst_parser the text must be passed as explicit string.

This PR ensures the title_text from self.default_title in custom_admonitions.py is converted from <class 'sphinx.locale._TranslationProxy'> to string.

This PR fixed #196.

@jbms jbms merged commit f22d5f8 into jbms:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2bndy5 2bndy5 2bndy5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception raised with MyST / mardown-it renderer
3 participants
@matthias-colt @2bndy5 @jbms