[JDF-152] helloworld-mdb demonstrates JMS topic #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed the EOL stuff |
|
Very nice! I tested the local deployment and it works great. I still need to test the OpenShift. @pmuir : Do you want to review the code? |
|
@sgilda I have amended the code with your remarks |
|
@jmesnil : One last minor comment. 'Under Build and Deploy the Quickstart', the new console log messages need to be indented 4 more spaces to render correctly in the HTML. |
* add a 2nd MDB which receives messages from a topic * let the servlet sends messageis either to the queue or to the topic (by adding the topic HTTP request parameter) * update the README and remove the section about configuring the messaging subsystem for OpenShift, .openshift/config/standalone.xml is already properly configured for both AS7 and EAP6
|
good catch, I've fixed it. |
|
Looks good to me. |
|
Thanks Pete. Merged! |
emmartins
added a commit
that referenced
this pull request
Mar 25, 2020
[WFLY-12490] Propagating changes from WFLY-12460 and WFLY-12418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(by adding the topic HTTP request parameter)
messaging subsystem for OpenShift, .openshift/config/standalone.xml is
already properly configured for both AS7 and EAP6
The files EOL were using Windows format. I assumed it was an error and saved them using UNIX format