JDF 149 - shows how to use DeltaSpike BeanManagerProvider to access CDI in a EntityListener #365

rafabene · 2012-11-28T19:19:41Z

No description provided.

rafabene · 2012-11-29T16:43:19Z

This is ready for review

sgilda · 2012-11-29T18:09:58Z

deltaspike-beanmanagerprovider/README.md

+Technologies: CDI, Deltaspike, JPA, JSF
+Summary: Shows how to use DeltaSpike BeanManagerProvider to access CDI in a EntityListener
+Prerequisites: 
+Target Product: 


per @pmuir, target product is WFK

sgilda · 2012-11-29T18:53:37Z

@rafabene : Very nice! Tested this and it works great! I made a few minor suggestions for the README file.

I would like to see instructions on the rendered application page, similar to the comments in the README.

To insert a new contact, click the New Contact button, complete the form fields, and then click the Save button. Notice that both the All Contacts and Audit Records tables are updated.
To modify an existing contact, find the name in the All Contacts table and click the Select for edit button. Modify the data and then click the Save button. Notice that the Audit Records table is updated with the new contact data.,
To remove a contact, find the name in the All Contacts table and click the Remove button. Notice that the Audit Records table is updated with the new contact data.,

But I'm afraid it might take up to much real estate on the page.

Looks good to me!

sgilda · 2012-11-29T19:03:34Z

deltaspike-beanmanagerprovider/README.md

+
+Create, edit or remove some contacts to see the audit records being registered.
+
+_NOTE: To fire the update audit, you must change one of the contact fields


This doesn't render properly. It's missing the ending underscore, :-)
NOTE: To fire the update audit, you must change one of the contact fields

sgilda · 2012-11-29T19:04:50Z

@pmuir: This is ready for your technical review :-).

pmuir · 2012-11-30T15:13:17Z

deltaspike-beanmanagerprovider/README.md

+
+This project demonstrates the use of DeltaSpike's BeanManagerProvider.  
+
+BeanmanagerProvider provides access to the BeanManager by registering the current BeanManager during the startup. This is really handy if you like to access CDI functionality from places where no CDI based injection is available. If a simple but manual bean-lookup is needed, it's easier to use the BeanProvider. 


The last sentence is a bit confusing. Maybe "If a simple but manual bean-lookup is needed, it's easier to use BeanProvider instead"

Also, you should use backticks to enclose references to classes e.g. BeanProvider

pmuir · 2012-11-30T15:22:00Z

looks good, but it's very short on javadoc and comments. We need to increase this. Pretend you are writing this as a real app, as well as a tutorial.

rafabene · 2012-12-03T15:11:23Z

I think that's better now :)

sgilda · 2012-12-20T20:49:14Z

deltaspike-beanmanagerprovider/README.md

@@ -0,0 +1,95 @@
+jboss-as-deltaspike-beanmanager: Shows how to use DeltaSpike BeanManagerProvider to access CDI in a EntityListener


The quickstart name doesn't match the quickstart folder name. This name should probably be deltaspike-beanmanagerprovider to match the folder name. Also, the "jboss-as" prefix is only used in the URL to access the application. :-)

sgilda · 2012-12-20T20:55:20Z

Ohter than changing the quickstart name in the first line of the README.md file from jboss-as-deltaspike-beanmanager to deltaspike-beanmanagerprovider to match the folder name, this looks good to me!

@pmuir , do you need to review this?

pmuir · 2012-12-21T15:53:02Z

...va/org/jboss/as/quickstarts/deltaspike/beanmanagerprovider/controller/ContactController.java

+
+    /**
+     * This method will promote the conversation when this component is constructed through the {@link PostConstruct} annotation
+     * This will also create a new entity to be managed/edited


Where do you end the conversation?

Actually this is never ended since the user has no option to leave the screen :0

I think you should add a comment to that effect. Explain what is going on there.

pmuir · 2012-12-22T21:53:04Z

Pretty short on comments still. Every file, every public method needs at least one javadoc comment explaining what it is for. Put comments about the implementation into normal comments.

sgilda · 2013-01-02T19:34:21Z

The instructions are a big help!

I'm being a little picky here, but it's hard to distinguish button and table names in the instructions for the running application. Is it possible to use quotes or italics for the form title and button names in the contactsCRUD.xhtml like this:

To insert a new contact: Click the New Contact button, complete the form fields, and then click the Save button. Notice that both the All Contacts and Audit Records tables are updated.
To modify an existing contact: Find the name in the All Contacts table and click the Select for edit button. Modify the data and then click the Save button. Notice that the Audit Records table is updated with the new contact data.
To remove a contact: Find the name in the All Contacts table and click the Remove button. Notice that the Audit Records table is updated with the new contact data.

I wonder if it would look better with the form fields and everything else left aligned. It looks a little odd to me now with the Contacts title, result message, form fields, and *Note centered, while the rest is left aligned.

sgilda · 2013-01-15T17:49:01Z

Looks good.
Pete, are you OK with this one now? If so, I will merge.

pmuir · 2013-01-16T16:14:39Z

Looks good.

sgilda · 2013-01-16T17:57:30Z

I get conflicts when I rebase upstream/master:
$ git rebase upstream/master
First, rewinding head to replay your work on top of it...
Applying: Initial commit
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging README.md
CONFLICT (add/add): Merge conflict in README.md
Auto-merging .gitignore
CONFLICT (add/add): Merge conflict in .gitignore
Failed to merge in the changes.
Patch failed at 0001 Initial commit
The copy of the patch that failed is found in:
/home/sgilda/GitRepos/quickstart-jdf/.git/rebase-apply/patch

For some reason, the README.md file has this at the end:
+deltaspike-quickstarts
+======================
+
+Holds some Deltaspike quickstarts

The .gitignore also has errors.

@rafabene : this could be due to your initial commit. It looks like you check in a root README.md file and a .gitignore file. These are messing it up. :-)

sgilda · 2013-01-16T18:10:20Z

Rebased upstream, squashed the commits, and merged.

rafabene added 4 commits November 22, 2012 05:41

Initial commit

2dcdf38

Updated gitignore

093e0e9

BeanManagerProvider quickstart added

109c926

Improved timezone using CDI @produces and added @Enumerated

8d030c3

sgilda reviewed Nov 29, 2012
View reviewed changes

pmuir reviewed Nov 30, 2012
View reviewed changes

Added Pete and Sande's review

dadff61

merge from remotes/deltaspike/JDF-149

d4fbe27

sgilda reviewed Dec 20, 2012
View reviewed changes

pmuir reviewed Dec 21, 2012
View reviewed changes

Some corrections based on Pull Request #365 comments

9c18015

Align left and make some items italic

80876b7

sgilda closed this Jan 16, 2013

rafabene deleted the JDF-149 branch January 29, 2013 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDF 149 - shows how to use DeltaSpike BeanManagerProvider to access CDI in a EntityListener #365

JDF 149 - shows how to use DeltaSpike BeanManagerProvider to access CDI in a EntityListener #365

rafabene commented Nov 28, 2012

rafabene commented Nov 29, 2012

sgilda Nov 29, 2012

sgilda commented Nov 29, 2012

sgilda Nov 29, 2012

sgilda commented Nov 29, 2012

pmuir Nov 30, 2012

pmuir Nov 30, 2012

pmuir commented Nov 30, 2012

rafabene commented Dec 3, 2012

sgilda Dec 20, 2012

sgilda commented Dec 20, 2012

pmuir Dec 21, 2012

rafabene Dec 27, 2012

pmuir Jan 16, 2013

pmuir commented Dec 22, 2012

sgilda commented Jan 2, 2013

sgilda commented Jan 15, 2013

pmuir commented Jan 16, 2013

sgilda commented Jan 16, 2013

sgilda commented Jan 16, 2013


		Create, edit or remove some contacts to see the audit records being registered.

		_NOTE: To fire the update audit, you must change one of the contact fields


		This project demonstrates the use of DeltaSpike's BeanManagerProvider.

		BeanmanagerProvider provides access to the BeanManager by registering the current BeanManager during the startup. This is really handy if you like to access CDI functionality from places where no CDI based injection is available. If a simple but manual bean-lookup is needed, it's easier to use the BeanProvider.

		@@ -0,0 +1,95 @@
		jboss-as-deltaspike-beanmanager: Shows how to use DeltaSpike BeanManagerProvider to access CDI in a EntityListener

JDF 149 - shows how to use DeltaSpike BeanManagerProvider to access CDI in a EntityListener #365

JDF 149 - shows how to use DeltaSpike BeanManagerProvider to access CDI in a EntityListener #365

Conversation

rafabene commented Nov 28, 2012

rafabene commented Nov 29, 2012

Choose a reason for hiding this comment

sgilda commented Nov 29, 2012

Choose a reason for hiding this comment

sgilda commented Nov 29, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pmuir commented Nov 30, 2012

rafabene commented Dec 3, 2012

Choose a reason for hiding this comment

sgilda commented Dec 20, 2012

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pmuir commented Dec 22, 2012

sgilda commented Jan 2, 2013

sgilda commented Jan 15, 2013

pmuir commented Jan 16, 2013

sgilda commented Jan 16, 2013

sgilda commented Jan 16, 2013