Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDF-178 Add exception handling to kitchensink-deltaspike #385

Closed
wants to merge 2 commits into from
Closed

JDF-178 Add exception handling to kitchensink-deltaspike #385

wants to merge 2 commits into from

Conversation

rafabene
Copy link
Contributor

No description provided.

@sgilda
Copy link
Contributor

sgilda commented Jan 2, 2013

I tested this and it looks good to me.

@pmuir : Do you need to review these changes?

@pmuir
Copy link
Contributor

pmuir commented Jan 9, 2013

Looks good.

@rafabene rafabene closed this Jan 14, 2013
@rafabene
Copy link
Contributor Author

I will review the PR

@rafabene rafabene reopened this Jan 15, 2013
@sgilda
Copy link
Contributor

sgilda commented Jan 15, 2013

Looks good. Still works. I'm fine with this.
@pmuir: do you need to review the code changes?

@pmuir
Copy link
Contributor

pmuir commented Jan 16, 2013

Looks good to me :-)

@sgilda
Copy link
Contributor

sgilda commented Jan 16, 2013

Merged upstream.

@sgilda sgilda closed this Jan 16, 2013
@rafabene rafabene deleted the JDF-178 branch January 29, 2013 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rafabene @sgilda @pmuir