Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ejb multi server #562

Closed
wants to merge 2 commits into from
Closed

Ejb multi server #562

wants to merge 2 commits into from

Conversation

wfink
Copy link
Contributor

@wfink wfink commented Jul 18, 2013

Add @ejb annotation and explanations to show how an EJB can be injected correctly.
Add comments and commands to be more clear how to run the examples

@sgilda
Copy link
Contributor

sgilda commented Jul 18, 2013

Hi Wolf,
I'm running into a few issues. The first time I tried running the install script, it hung and I saw exceptions in the server. I stopped and restarted the server and ran the script again. This time it said it completed successfully, but I see the following in the server log:

[Server:app-main] 12:07:14,742 INFO org.jboss.ejb.client.ClusterContext Added a new EJB receiver in cluster context ejb for node master:app-oneB. Total nodes in cluster context = 2
[Server:app-oneB] 12:07:14,877 INFO [org.jboss.as.server](host-controller-connection-threads - 1) JBAS015871: Deploy of deployment "appone.ear" was rolled back with no failure message
[Server:app-twoA] 12:07:14,878 INFO [org.jboss.as.server](host-controller-connection-threads - 1) JBAS015871: Deploy of deployment "apptwo.ear" was rolled back with no failure message
[Server:app-oneA] 12:07:14,878 INFO [org.jboss.as.server](host-controller-connection-threads - 1) JBAS015871: Deploy of deployment "appone.ear" was rolled back with no failure message
[Server:app-main] 12:07:14,885 INFO [org.jboss.as.server](host-controller-connection-threads - 1) JBAS015871: Deploy of deployment "appmain.ear" was rolled back with no failure message
[Server:app-twoB] 12:07:14,886 INFO [org.jboss.as.server](host-controller-connection-threads - 1) JBAS015871: Deploy of deployment "apptwo.ear" was rolled back with no failure message
[Server:app-main] 12:07:14,961 INFO [org.jboss.weld.deployer](MSC service thread 1-8) JBAS016009: Stopping weld service for deployment appmain.ear
[Server:app-oneB] 12:07:14,962 INFO org.infinispan.eviction.PassivationManagerImpl ISPN000029: Passivating all entries to disk
[Server:app-oneB] 12:07:14,963 INFO org.infinispan.eviction.PassivationManagerImpl ISPN000030: Passivated 0 entries in 1 milliseconds
[Server:app-oneB] 12:07:14,982 INFO org.jboss.as.clustering.infinispan JBAS010282: Stopped repl cache from ejb container
[Server:app-twoA] 12:07:14,986 INFO [org.jboss.as.server.deployment](MSC service thread 1-2) JBAS015877: Stopped deployment ejb.jar in 101ms
[Server:app-twoB] 12:07:14,986 INFO [org.jboss.as.server.deployment](MSC service thread 1-2) JBAS015877: Stopped deployment ejb.jar in 94ms
[Server:app-twoB] 12:07:14,990 INFO [org.jboss.as.server.deployment](MSC service thread 1-2) JBAS015877: Stopped deployment apptwo.ear in 99ms
[Server:app-twoA] 12:07:14,992 INFO [org.jboss.as.server.deployment](MSC service thread 1-8) JBAS015877: Stopped deployment apptwo.ear in 112ms
[Server:app-oneB] 12:07:15,011 INFO [org.jboss.as.server.deployment](MSC service thread 1-5) JBAS015877: Stopped deployment ejb.jar in 112ms
[Server:app-oneA] 12:07:15,017 INFO org.infinispan.eviction.PassivationManagerImpl ISPN000029: Passivating all entries to disk
[Server:app-oneA] 12:07:15,019 INFO org.infinispan.eviction.PassivationManagerImpl ISPN000030: Passivated 0 entries in 1 milliseconds
[Server:app-oneB] 12:07:15,018 INFO [org.jboss.as.server.deployment](MSC service thread 1-4) JBAS015877: Stopped deployment appone.ear in 121ms
[Server:app-oneA] 12:07:15,037 INFO org.jboss.as.clustering.infinispan JBAS010282: Stopped repl cache from ejb container
[Server:app-oneA] 12:07:15,037 INFO org.jboss.as.clustering.infinispan JBAS010282: Stopped remote-connector-client-mappings cache from ejb container
[Server:app-oneA] 12:07:15,061 INFO [org.jboss.as.server.deployment](MSC service thread 1-3) JBAS015877: Stopped deployment ejb.jar in 180ms
[Server:app-oneA] 12:07:15,066 INFO [org.jboss.as.server.deployment](MSC service thread 1-3) JBAS015877: Stopped deployment appone.ear in 187ms
[Server:app-main] 12:07:15,073 INFO [org.jboss.as.server.deployment](MSC service thread 1-1) JBAS015877: Stopped deployment ejb.jar in 184ms
[Server:app-main] 12:07:15,075 INFO [org.jboss.as.server.deployment](MSC service thread 1-8) JBAS015877: Stopped deployment jsf.war in 185ms
[Server:app-main] 12:07:15,078 INFO [org.jboss.as.server.deployment](MSC service thread 1-2) JBAS015877: Stopped deployment appmain.ear in 190ms
[Server:app-oneA] 12:07:15,133 INFO org.infinispan.remoting.transport.jgroups.JGroupsTransport ISPN000082: Stopping the RpcDispatcher
[Server:app-oneB] 12:07:15,155 ERROR org.jboss.as.clustering.impl.CoreGroupCommunicationService.ejb JBAS010245: ViewAccepted failed: java.lang.NullPointerException
[Server:app-oneB] at org.jboss.as.clustering.impl.CoreGroupCommunicationService$ClusterNodeFactoryImpl.getClusterNode(CoreGroupCommunicationService.java:1653) [jboss-as-clustering-impl-7.1.1.Final.jar:7.1.1.Final]
[Server:app-oneB] at org.jboss.as.clustering.impl.CoreGroupCommunicationService.translateAddresses(CoreGroupCommunicationService.java:1280) [jboss-as-clustering-impl-7.1.1.Final.jar:7.1.1.Final]
[Server:app-oneB] at org.jboss.as.clustering.impl.CoreGroupCommunicationService$GroupView.(CoreGroupCommunicationService.java:1371) [jboss-as-clustering-impl-7.1.1.Final.jar:7.1.1.Final]
[Server:app-oneB] at org.jboss.as.clustering.impl.CoreGroupCommunicationService.processViewChange(CoreGroupCommunicationService.java:1180) [jboss-as-clustering-impl-7.1.1.Final.jar:7.1.1.Final]
[Server:app-oneB] at org.jboss.as.clustering.impl.CoreGroupCommunicationService$MembershipListenerImpl.viewAccepted(CoreGroupCommunicationService.java:1727) [jboss-as-clustering-impl-7.1.1.Final.jar:7.1.1.Final]
[Server:app-oneB] at org.jgroups.blocks.MessageDispatcher$ProtocolAdapter.handleUpEvent(MessageDispatcher.java:506) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.blocks.MessageDispatcher$ProtocolAdapter.up(MessageDispatcher.java:545) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jboss.as.clustering.jgroups.ClassLoaderAwareUpHandler.up(ClassLoaderAwareUpHandler.java:56) [jboss-as-clustering-jgroups-7.1.1.Final.jar:7.1.1.Final]
[Server:app-oneB] at org.jgroups.blocks.mux.MuxUpHandler.passToAllHandlers(MuxUpHandler.java:156) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.blocks.mux.MuxUpHandler.up(MuxUpHandler.java:123) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jboss.as.clustering.jgroups.MuxChannel$ClassLoaderAwareMuxUpHandler.up(MuxChannel.java:64) [jboss-as-clustering-jgroups-7.1.1.Final.jar:7.1.1.Final]
[Server:app-oneB] at org.jgroups.JChannel.up(JChannel.java:716) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.stack.ProtocolStack.up(ProtocolStack.java:1026) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.FRAG2.up(FRAG2.java:181) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.FlowControl.up(FlowControl.java:418) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.FlowControl.up(FlowControl.java:418) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.pbcast.GMS.installView(GMS.java:625) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.pbcast.CoordGmsImpl.handleViewChange(CoordGmsImpl.java:247) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.pbcast.GMS.up(GMS.java:784) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.pbcast.STABLE.up(STABLE.java:244) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.UNICAST2.up(UNICAST2.java:383) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.pbcast.NAKACK.handleMessage(NAKACK.java:730) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.pbcast.NAKACK.up(NAKACK.java:559) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.BARRIER.up(BARRIER.java:126) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.VERIFY_SUSPECT.up(VERIFY_SUSPECT.java:140) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.FD.up(FD.java:273) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.FD_SOCK.up(FD_SOCK.java:282) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.MERGE2.up(MERGE2.java:205) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.Discovery.up(Discovery.java:355) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.stack.Protocol.up(Protocol.java:358) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.TP.passMessageUp(TP.java:1174) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.TP$4.run(TP.java:1097) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) [rt.jar:1.7.0_09]
[Server:app-oneB] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) [rt.jar:1.7.0_09]
[Server:app-oneB] at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_09]
[Server:app-oneB]
[Server:app-oneB] 12:07:15,172 INFO org.infinispan.remoting.transport.jgroups.JGroupsTransport ISPN000094: Received new cluster view: [master:app-oneB/ejb|2] [master:app-oneB/ejb]
[Server:app-oneB] 12:07:45,039 WARN org.infinispan.transaction.TransactionTable ISPN000100: Stopping, but there are transactions that did not finish in time: localTransactions={}, remoteTransactions{GlobalTransaction:master:app-oneA/ejb:2:remote=RemoteTransaction{modifications=[RemoveCommand{key=master:app-oneA/ejb, value=null, flags=null}], lookedUpEntries={master:app-oneA/ejb=ReadCommittedEntry(2c4c85e6){key=master:app-oneA/ejb, value=MarshalledValue{instance=master:app-oneA=[org.jboss.as.network.ClientMapping@53ead5c2], serialized=ByteArray{size=504, array=0x0301fe0409000000..}, cachedHashCode=-366143632}@fb6fd9c, oldValue=MarshalledValue{instance=master:app-oneA=[org.jboss.as.network.ClientMapping@53ead5c2], serialized=ByteArray{size=504, array=0x0301fe0409000000..}, cachedHashCode=-366143632}@fb6fd9c, isCreated=false, isChanged=true, isRemoved=true, isValid=false}}, lockedKeys= [master:app-oneA/ejb], backupKeyLocks null, isMissingModifications false, tx=GlobalTransaction:master:app-oneA/ejb:2:remote}}
[Server:app-oneB] 12:07:45,047 INFO org.jboss.as.clustering.infinispan JBAS010282: Stopped remote-connector-client-mappings cache from ejb container
[Server:app-oneB] 12:07:45,150 INFO org.infinispan.remoting.transport.jgroups.JGroupsTransport ISPN000082: Stopping the RpcDispatcher

Once again, I stopped and started my server. It appears the apps deployed, but I'm seeing OutOfMemoryErrors:

[Server:app-oneB] 12:10:48,594 INFO org.infinispan.remoting.transport.jgroups.JGroupsTransport ISPN000094: Received new cluster view: [master:app-oneB/ejb|1] [master:app-oneB/ejb, master:app-oneA/ejb]
[Server:app-oneB] 12:10:48,606 SEVERE [org.jgroups.protocols.UDP](multicast receiver,null) failed handling data from 192.168.1.107:45688: java.lang.OutOfMemoryError: unable to create new native thread
[Server:app-oneB] at java.lang.Thread.start0(Native Method) [rt.jar:1.7.0_09]
[Server:app-oneB] at java.lang.Thread.start(Thread.java:691) [rt.jar:1.7.0_09]
[Server:app-oneB] at java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:943) [rt.jar:1.7.0_09]
[Server:app-oneB] at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1325) [rt.jar:1.7.0_09]
[Server:app-oneB] at org.jgroups.protocols.TP.dispatchToThreadPool(TP.java:1221) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.TP.receive(TP.java:1198) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:683) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_09]
[Server:app-oneB]
[Server:app-oneB] 12:10:48,608 SEVERE [org.jgroups.protocols.UDP](unicast receiver,null) failed handling data from 127.0.0.1:55300: java.lang.OutOfMemoryError: unable to create new native thread
[Server:app-oneB] at java.lang.Thread.start0(Native Method) [rt.jar:1.7.0_09]
[Server:app-oneB] at java.lang.Thread.start(Thread.java:691) [rt.jar:1.7.0_09]
[Server:app-oneB] at java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:943) [rt.jar:1.7.0_09]
[Server:app-oneB] at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1325) [rt.jar:1.7.0_09]
[Server:app-oneB] at org.jgroups.protocols.TP.dispatchToThreadPool(TP.java:1221) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.TP.receive(TP.java:1198) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:683) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_09]
[Server:app-oneB]
[Server:app-oneB] 12:10:48,610 SEVERE [org.jgroups.protocols.UDP](unicast receiver,null) failed handling data from 127.0.0.1:55300: java.lang.OutOfMemoryError: unable to create new native thread
[Server:app-oneB] at java.lang.Thread.start0(Native Method) [rt.jar:1.7.0_09]
[Server:app-oneB] at java.lang.Thread.start(Thread.java:691) [rt.jar:1.7.0_09]
[Server:app-oneB] at java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:943) [rt.jar:1.7.0_09]
[Server:app-oneB] at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1325) [rt.jar:1.7.0_09]
[Server:app-oneB] at org.jgroups.protocols.TP.dispatchToThreadPool(TP.java:1221) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.TP.receive(TP.java:1198) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at org.jgroups.protocols.UDP$PacketReceiver.run(UDP.java:683) [jgroups-3.0.6.Final.jar:3.0.6.Final]
[Server:app-oneB] at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_09]
[Server:app-oneB]
[Server:app-oneA] 12:10:48,621 ERROR [org.jboss.msc.service.fail](MSC service thread 1-1) MSC00001: Failed to start service jboss.infinispan.ejb: org.jboss.msc.service.StartException in service jboss.infinispan.ejb: Failed to start service
[Server:app-oneA] at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1767) [jboss-msc-1.0.2.GA.jar:1.0.2.GA]
[Server:app-oneA] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) [rt.jar:1.7.0_09]
[Server:app-oneA] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) [rt.jar:1.7.0_09]
[Server:app-oneA] at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_09]
[Server:app-oneA] Caused by: java.lang.OutOfMemoryError: unable to create new native thread
[Server:app-oneA] at java.lang.Thread.start0(Native Method) [rt.jar:1.7.0_09]
[Server:app-oneA] at java.lang.Thread.start(Thread.java:691) [rt.jar:1.7.0_09]
[Server:app-oneA] at java.util.concurrent.ThreadPoolExecutor.addWorker(ThreadPoolExecutor.java:943) [rt.jar:1.7.0_09]
[Server:app-oneA] at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1336) [rt.jar:1.7.0_09]
[Server:app-oneA] at org.jboss.as.clustering.msc.AsynchronousService.start(AsynchronousService.java:67)
[Server:app-oneA] at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc-1.0.2.GA.jar:1.0.2.GA]
[Server:app-oneA] at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc-1.0.2.GA.jar:1.0.2.GA]
[Server:app-oneA] ... 3 more
[Server:app-oneA]
[Server:app-oneA] 12:10:49,260 INFO [org.jboss.as.server](Controller Boot Thread) JBAS018559: Deployed "appone.ear"
[Server:app-oneA] 12:10:49,263 INFO [org.jboss.as.controller](Controller Boot Thread) JBAS014774: Service status report
[Server:app-oneA] JBAS014777: Services which failed to start: service jboss.infinispan.ejb: org.jboss.msc.service.StartException in service jboss.infinispan.ejb: Failed to start service
[Server:app-oneA]
[Server:app-oneA] 12:10:49,267 ERROR [org.jboss.as](Controller Boot Thread) JBAS015875: JBoss AS 7.1.1.Final "Brontes" started (with errors) in 22193ms - Started 171 of 314 services (13 services failed or missing dependencies, 129 services are passive or on-demand)
[Server:app-oneB] 12:10:53,599 WARNING org.jgroups.protocols.pbcast.GMS master:app-oneB/ejb: failed to collect all ACKs (expected=1) for unicast view [master:app-oneB/ejb|1] [master:app-oneB/ejb, master:app-oneA/ejb] after 5000ms, missing ACKs from [master:app-oneA/ejb]

Do we need to modify the JAVA_OPTS? This is from my server start for 7.1.1:

JAVA_OPTS: -Xms64m -Xmx512m -XX:MaxPermSize=256m -Djava.net.preferIPv4Stack=true -Dorg.jboss.resolver.warning=true -Dsun.rmi.dgc.client.gcInterval=3600000 -Dsun.rmi.dgc.server.gcInterval=3600000 -Djboss.modules.system.pkgs=org.jboss.byteman -Djava.awt.headless=true -Djboss.domain.default.config=domain.xml -Djboss.host.default.config=host.xml

I tried upping it to -Xms256 with no luck.

@wfink
Copy link
Contributor Author

wfink commented Jul 19, 2013

I don't think that this will have any relation to the current PR. I've checked it with AS7.2.0 and EAP6.1 as the install script can be used for this without modifications.
The NPE look like a race condition which is solved later in 7.1
With the heap I think your machine has issues as there are 8 JVM started which need heap. If you increase the JAVA_OPTS it only affect the PROCESS and HOST controller.

Nevertheless the shown errors, after I restart after install and deploy, add the users the test works fine with 7.1.1 on my system

@@ -136,12 +139,23 @@ Access the Remote Client Application

mvn exec:java -DUseEjbClient34=true

The invocation of `appTwo` will not work since the secured method will be called and there is no Role for the user defined. Try to update the user `quickuser1` and `quickuser2` and give them one of the Roles `AppTwo` or `Intern`. After that the invocation will be successful. The log output of the `appTwo` servers shows which Role is applied to the user. The output of the client will show you a simple line with the information provided by the different applications:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be a good idea to make the failure more obvious here. Maybe something like:

The invocation of `appTwo` throws a  `java.lang.reflect.InvocationTargetException` since the secured method is called and there is no Role for the user defined.  You get a `BUILD FAILURE` and the client outputs the following information:

    [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:java (default-cli) on project jboss-as-ejb-multi-server-client: An exception occured while executing the Java class. null: InvocationTargetException: JBAS014502: Invocation on method: public abstract java.lang.String org.jboss.as.quickstarts.ejb.multi.server.app.AppTwo.invokeSecured(java.lang.String) of bean: AppTwoBean is not allowed -> [Help 1]

Update the user `quickuser1` and `quickuser2` and give them one of the Roles `AppTwo` or `Intern`.

@sgilda
Copy link
Contributor

sgilda commented Jul 19, 2013

@wfink : This works great. I was able to get through all the testing, however, when I stop and start the server to make changes, for example, editing the user role properties to add the roles, my server always gets OutOfMemoryErrors. One time I had to reboot. I wonder if we should say up front that this quickstart requires a lot of resources and they may need to shut down processes or reboot in between testing?

Other than that, if you can make the changes above, this one looks good to merge.

@sgilda
Copy link
Contributor

sgilda commented Aug 6, 2013

@pmuir: Would you like someone to a code review?

@rafabene
Copy link
Contributor

rafabene commented Aug 6, 2013

I didn't check this PR but the existing code on master (https://github.com/jboss-jdf/jboss-as-quickstart/tree/master/ejb-multi-server) contains a lot of violations by FileHeaderChecker, LicenseChecker, FinalNameChecker, PomElementOrderChecker, PropertiesNameChecker, SamePropertyValueChecker and mainly IndentationChecker

It should be fine that we can fix this violations also before merging.

Once more: I didn't check this PR. This info is based on the existing master

@sgilda
Copy link
Contributor

sgilda commented Aug 7, 2013

Rafael, thanks for checking this.

@wfink : Could you please run the QS Tools utility and fix any issues? Thanks!

@pmuir
Copy link
Contributor

pmuir commented Aug 19, 2013

Looks ok to me.

@sgilda
Copy link
Contributor

sgilda commented Aug 21, 2013

Sent an email to Wolf on Aug. 19 about the formatting and license errors in this one.

@sgilda
Copy link
Contributor

sgilda commented Aug 29, 2013

@wfink: This still needs some README updates and some fixes to issues reported by the QSTools utility (license headers, formatting, etc.).

@sgilda
Copy link
Contributor

sgilda commented Aug 29, 2013

@wfink: I made the README updates and merged. Daniel will fix the formatting and other QSTools errors.

@sgilda sgilda closed this Aug 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants