Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDF-412 - Move JDG Quickstarts to git submodules #565

Merged
merged 1 commit into from
Jul 22, 2013
Merged

JDF-412 - Move JDG Quickstarts to git submodules #565

merged 1 commit into from
Jul 22, 2013

Conversation

rafabene
Copy link
Contributor

No description provided.

@ghost ghost assigned sgilda Jul 22, 2013
@sgilda
Copy link
Contributor

sgilda commented Jul 22, 2013

@rafabene : This looks good to me. I do have one question though.

In the root pom.xml file, you removed the individual jdg quickstart modules and replaced them with just the root directory for the new submodule:

    <module>jdg-quickstarts</module>

I noticed the richfaces-quickstart commit replaced them with complete paths:

    <module>richfaces-quickstarts/helloworld-rf</module>
    <module>richfaces-quickstarts/kitchensink-rf</module>

I assume it's because that repository does not have a root pom.xml file. I think the richfaces quickstart repository should add a root pom.xml and the richfaces-quickstarts individual quickstart modules should be replaced by one only naming the root directory? Do you agree?.

@rafabene
Copy link
Contributor Author

Well. To avoid different kinds of submodules (direct one vs root pom) we can add it to richfaces repo and open a PR for them.

@rafabene
Copy link
Contributor Author

Since this enhancement doesn't change the result for jdf or richfaces. I think this pom.xml addition could be done on another PR. Do you agree?

@sgilda
Copy link
Contributor

sgilda commented Jul 22, 2013

Definitely! I just wanted to ask you while it was fresh in my mind. :-)

This pull looks fine! Would you like me to merge it?

@sgilda sgilda merged commit 3708f50 into jboss-developer:master Jul 22, 2013
fjuma pushed a commit to fjuma/quickstart that referenced this pull request Aug 18, 2022
[WFLY-16140] Remove outdated/redundant quickstarts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants