Maximize workbench shell & make sure its visible when tests are started #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawagner
added a commit
to rawagner/reddeer
that referenced
this pull request
Jan 20, 2017
rawagner
force-pushed
the
maximize_workbench
branch
from
82cfdd5
to
bfb2c52
Compare
rawagner
added a commit
to rawagner/reddeer
that referenced
this pull request
Jan 20, 2017
|
testPR |
rawagner
force-pushed
the
maximize_workbench
branch
from
bfb2c52
to
d6cb739
Compare
rawagner
added a commit
to rawagner/reddeer
that referenced
this pull request
Jan 24, 2017
rawagner
force-pushed
the
maximize_workbench
branch
from
d6cb739
to
02f8a8f
Compare
rawagner
added a commit
to rawagner/reddeer
that referenced
this pull request
Jan 25, 2017
|
Could you please add tests with a custom shell? E.g. create a new shell, perform operations on it and check whether it is in expected state. |
rawagner
force-pushed
the
maximize_workbench
branch
from
02f8a8f
to
ea45817
Compare
rawagner
added a commit
to rawagner/reddeer
that referenced
this pull request
Feb 1, 2017
rawagner
force-pushed
the
maximize_workbench
branch
from
ea45817
to
6ca3ec8
Compare
rawagner
added a commit
to rawagner/reddeer
that referenced
this pull request
Feb 2, 2017
|
testPR |
mlabuda
suggested changes
Feb 3, 2017
| * | ||
| * Contributors: | ||
| * Red Hat, Inc. - initial API and implementation | ||
| ******************************************************************************/ |
There was a problem hiding this comment.
please move license header at the top of the file.
rawagner
force-pushed
the
maximize_workbench
branch
from
6ca3ec8
to
5afac6a
Compare
mlabuda
approved these changes
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.