Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate Helpers - introduce common, object to allow greater detail of error? #89

Open
baranowb opened this issue Dec 13, 2017 · 3 comments

Comments

@baranowb
Copy link
Contributor

Right now, due to shortcomings of drools we either stick to simple checks or move code to java helpers, which return true /false. possibly we could either add argument or return value which could provide greater detail of error reporting?

Just a thought.

@rpelisse
Copy link
Contributor

Why not ? I think anyway, after the Janitor integration, we will need to seriously enhance/rework some part of Bugclerk. Perfect time to also think about that!

@baranowb
Copy link
Contributor Author

Not only this. This will allow more fine grained checks. ie, if pull requests need to be scrutinized, with current helpers it is possible to trigger violation on single instance of PR+issue pair, rather than for each violation. Sure, in the end, after N iterations, you will see all of them.

@rpelisse
Copy link
Contributor

An exemple of a method that could be moved to Aphrodite for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants