Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EJBCLIENT-126 Use Message Format Patterns #85

Merged
merged 1 commit into from Jan 6, 2015

Conversation

marschall
Copy link
Contributor

Most of the JBoss code uses message format patterns for debug logging
in order to avoid unnecessary allocations in normal operation. The
JBoss EJB client seems to be one of the few places where this is not
yet the case and debug messages are always created even if the debug
logging is disabled.

  • use #debugf for debug logging
  • use #isDebugEnabled for debug statements too complex for #debugf

Issue: EJBCLIENT-126
https://issues.jboss.org/browse/EJBCLIENT-126

Most of the JBoss code uses message format patterns for debug logging
in order to avoid unnecessary allocations in normal operation. The
JBoss EJB client seems to be one of the few places where this is not
yet the case and debug messages are always created even if the debug
logging is disabled.

 * use `#debugf` for debug logging
 * use `#isDebugEnabled` for debug statements too complex for `#debugf`

Issue: EJBCLIENT-126
https://issues.jboss.org/browse/EJBCLIENT-126
@dmlloyd dmlloyd merged commit 3c37607 into wildfly:master Jan 6, 2015
dmlloyd added a commit that referenced this pull request Jan 6, 2015
…dFly-8.1.0.Final_EAP_6.3.0

Add versions for WildFly 8.1.0.Final and EAP 6.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants