Skip to content
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.

Use classpath default output for generated sources #32

Closed
WonderCsabo opened this issue Sep 9, 2014 · 5 comments
Closed

Use classpath default output for generated sources #32

WonderCsabo opened this issue Sep 9, 2014 · 5 comments
Milestone

Comments

@WonderCsabo
Copy link
Contributor

Currently the output for the generated sources classpath entry is set to the outputDirectory parameter from the POM directly (mavenProject.getBuild().getOutputDirectory()). I think m2e-apt should not set this value directly from the pom, but it should rely on the default output directory:

<classpathentry kind="output" path="target/classes"/>

The default output directory is already set to the POM value by m2e, so it is the same as the current value by default. But some m2e configurators can modify this default output to another value, and ignore the setting in the POM. For example this is the case with m2e-android, which must compile everything to the bin folder (rgladwell/m2e-android#258). In that case it is crucial to not hardcode the output to the POM value, but let it be the default. If no m2e configurator change the default output value, we still have no problems, because it is already set by m2e.

@fbricon what do you think?

@fbricon
Copy link
Member

fbricon commented Sep 9, 2014

Seems reasonable. Wanna make a PR?

@WonderCsabo
Copy link
Contributor Author

Thanks for the super-fast response!
Sure, i can create a PR.

BTW, can you answer to my other issue (29)?

@fbricon
Copy link
Member

fbricon commented Sep 9, 2014

Thanks for the PR. Merged.

@fbricon fbricon closed this as completed Sep 9, 2014
@WonderCsabo
Copy link
Contributor Author

THX for merging!
Btw i still did not get an answer for issue 29, i also proposed a PR. Sorry for spamming here with that, but answering here fast and not there at all makes me feel you do not get the notifications from that thread somehow.

@fbricon
Copy link
Member

fbricon commented Sep 9, 2014

I'm back from PTO and close to email bankruptcy :-)

@fbricon fbricon added this to the 1.1.1 milestone Nov 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants