You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 18, 2022. It is now read-only.
Currently the output for the generated sources classpath entry is set to the outputDirectory parameter from the POM directly (mavenProject.getBuild().getOutputDirectory()). I think m2e-apt should not set this value directly from the pom, but it should rely on the default output directory:
The default output directory is already set to the POM value by m2e, so it is the same as the current value by default. But some m2e configurators can modify this default output to another value, and ignore the setting in the POM. For example this is the case with m2e-android, which must compile everything to the bin folder (rgladwell/m2e-android#258). In that case it is crucial to not hardcode the output to the POM value, but let it be the default. If no m2e configurator change the default output value, we still have no problems, because it is already set by m2e.
THX for merging!
Btw i still did not get an answer for issue 29, i also proposed a PR. Sorry for spamming here with that, but answering here fast and not there at all makes me feel you do not get the notifications from that thread somehow.
Currently the output for the generated sources classpath entry is set to the
outputDirectory
parameter from the POM directly (mavenProject.getBuild().getOutputDirectory()
). I think m2e-apt should not set this value directly from the pom, but it should rely on the default output directory:The default output directory is already set to the POM value by m2e, so it is the same as the current value by default. But some m2e configurators can modify this default output to another value, and ignore the setting in the POM. For example this is the case with
m2e-android
, which must compile everything to thebin
folder (rgladwell/m2e-android#258). In that case it is crucial to not hardcode the output to the POM value, but let it be the default. If no m2e configurator change the default output value, we still have no problems, because it is already set by m2e.@fbricon what do you think?
The text was updated successfully, but these errors were encountered: