New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Gray protected branches if not enabled by repo flag. #410

Closed
wilsoc5 opened this Issue Apr 3, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@wilsoc5

wilsoc5 commented Apr 3, 2015

It would be nice to gray out all Protected Branches entries if the repository setting "Enable protected branches" is unchecked. This is especially true in the case of adding a protected branch and forgetting to check the "Enable protected branches" box. Having a visual cue would be very helpful. Even a box saying that "The protected branches below are not enabled. Please enable Protected Branches in the repository settings above."

Alternatively, adding an Enable flag for each branch name and removing the repository-wide flag might be a better long-term option. The enable flag could just add a comment marker on the line in the gitolite.conf file.

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Apr 4, 2015

Member

Alternatively, adding an Enable flag for each branch name and removing the repository-wide flag might be a better long-term option.

Why not... For now I'm thinking about creating a relation table to manage users rather than a serialized field...

Member

n-rodriguez commented Apr 4, 2015

Alternatively, adding an Enable flag for each branch name and removing the repository-wide flag might be a better long-term option.

Why not... For now I'm thinking about creating a relation table to manage users rather than a serialized field...

@n-rodriguez n-rodriguez self-assigned this Apr 4, 2015

@n-rodriguez n-rodriguez added this to the v1.0.4 milestone Apr 4, 2015

n-rodriguez added a commit that referenced this issue Apr 4, 2015

@n-rodriguez

This comment has been minimized.

Show comment
Hide comment
@n-rodriguez

n-rodriguez Apr 10, 2015

Member

Why not... For now I'm thinking about creating a relation table to manage users rather than a serialized field...

It will be for next release.

Member

n-rodriguez commented Apr 10, 2015

Why not... For now I'm thinking about creating a relation table to manage users rather than a serialized field...

It will be for next release.

@n-rodriguez n-rodriguez changed the title from Feature Request: Gray protected branches if not enabled by repo flag. to [Feature Request] Gray protected branches if not enabled by repo flag. Jan 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment