Test interp nominal lon #365
Conversation
There was a problem hiding this comment.
Thanks for putting in more work into polishing this up @JoranAngevaare! I would much prefer to keep this in pure pytest, but I might also be missing something here.
| @@ -191,6 +193,57 @@ def test_replace_x_y_nominal_lat_lon(dask, nans): | |||
| assert set(replaced_ds.lat.dims) == set(["x", "y"]) | |||
|
|
|||
|
|
|||
| class TestReplaceXYNominalLatLon(TestCase): | |||
There was a problem hiding this comment.
I am not really familiar with unittest. Is there a specific reason not to use pytest fixtures (or plain functions) in this case?
There was a problem hiding this comment.
Unittest comes with a few handy tools. I personally like it a lot because plain functions - in my experience - sometimes increase code duplication and add clutter for setting up some dummy data. Truthfully, I only use TestCase.assertRaises and TestCase.assertTrue which I can easily replace with some plain code, and this specific test is really simple to do without things from Unittest. I'll change it.
Fix test for
_interp_nominal_lonThis PR is some leftover work from #296 (and #300)
replace_x_y_nominal_lat_londoes not work for > 360loncoordinates #295._interp_nominal_lon#296PR checks
replace_x_y_nominal_lat_londoes not work for > 360loncoordinates #295, Adding new contributors to CITATION.cff #358pre-commit run --all-fileswhats-new.rstapi.rst