New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded database support #13
Comments
I tried to implement these changes myself, but I hit a bit of a wall. I added the dotenv library and moved the environment variables previously in the launch commands to the
I don't think it's an issue with the library, but there's not much documentation on the npm package. I don't have a lot of experience with nodejs or successfully using es6 libraries so maybe you can point out what I've done wrong here. |
Figured out my issue, it's a commonjs module. Have to initialize with |
sorry, im not really considering adding this as the app already has docker support and ive resolved #12 earlier to allow using external dbs by providing your own connection string. if you want to use expanse without docker just run also note that this embedded-postgres package is made for testing, it says specifically on their homepage. so im not going to accept the PR but of course you can keep it in your own fork if it's useful to you. |
While browsing this repo I noticed from the compose.prod.yaml that expanse is a node.js application who's only dependency outside the NodeJS ecosystem is postgres, a database application. It looks to me like docker is used to run an instance of postgres as a dependency of expanse, but npm also has various embedded database libraries, and there's even embedded-postgres. Using one of these would allow the removal of docker as a requirement, which opens up many more options for packaging expanse, especially using existing automated tools for nodejs packaging. Using an embedded database by default and allowing the user to configure an external database at their preference provides a much higher degree of portability to the software that self-hosters like myself would much appreciate.
The text was updated successfully, but these errors were encountered: